Performance improvement of the outgoing products page when editing OCs #5822
Conversation
luisramos0
changed the title
|
Hey @luisramos0 , Thank you for this fix! |
|
for some reason, it refused to run the build. You might need to push force @luisramos0 . Manually retrying fails too
|
This relation is only used above for a call to empty? so we don't need to worry about the select part of the query, specially not introducing an expensive DISTINCT
luisramos0
force-pushed
the
improve_ocs_perf
branch
from
3d8b6b7
to
2aa6c70
Compare
|
ok, force pushed, the build is there now 👍 |
|
Hi @luisramos0, I checked if the option "coordinator inventory only" is still working and tried to chase down faster page loads, for an OC with ~300 variants (id=203888). I had a few runs, on pressing "Expand All" and "Load All Variants". Also had a look at one with around ~700 variants (id=202632). Page loads did appear slightly faster, and I did not observe any issues related to #5813 . Looks good to go - thanks for improving this. |
What? Why?
Testing #5775 in production we realized loading the enterprise is taking a very long time (15secs for the enterprise experiencing the bug, it's an OC with 400+ products coming from 20+ suppliers). I looked at the code I realized I could improve performance a little. See commit message.
This improvement will mitigate the problem in #5813, but wont solve it.
What should we test?
Like in #5775 verify the OC page, specifically outgoing exchanges, is still working with the option "coordinator inventory only". It should just be faster, I wonder if that can be seen before and after the PR :-)
Release notes
Changelog Category: Changed
Performance improvement of the outgoing products page when editing OCs with large numbers of products.