Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset order state to cart in case the stripe SCA authorization step fails #5824

Merged
merged 21 commits into from
Aug 1, 2020
Merged

Reset order state to cart in case the stripe SCA authorization step fails #5824

merged 21 commits into from
Aug 1, 2020

Commits on Jul 25, 2020

  1. Move method closer to related/similar methods

    @luisramos0
    luisramos0 committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    5266d95 View commit details
    Browse the repository at this point in the history

  2. Reused code in checkout controller, the reponse for the case when the… 

    …re is a stripe exception anywhere is the same as when the update action fails
    @luisramos0
    luisramos0 committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    1bf946d View commit details
    Browse the repository at this point in the history

  3. Notify bugsnag and execute post checkout actions (reset to cart state… 

    …) whenever there's a payment gateway exceeption raised
    @luisramos0
    luisramos0 committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    b23b707 View commit details
    Browse the repository at this point in the history

  4. Reuse update_failed method as the code needed is exactly the same

    @luisramos0
    luisramos0 committed Jul 25, 2020
    Configuration menu
    Copy the full SHA
    ec0d06a View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. Bring order checkout workflow and some of its specs from spree_core

    @luisramos0
    luisramos0 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    d8a96c9 View commit details
    Browse the repository at this point in the history

  2. Rubocop autocorrect and easy rubocop issues

    @luisramos0
    luisramos0 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    e99f0dc View commit details
    Browse the repository at this point in the history

  3. Fix specs in checkout_spec

    @luisramos0
    luisramos0 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    51de526 View commit details
    Browse the repository at this point in the history

  4. Transpec checkout_spec

    @luisramos0
    luisramos0 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    e80337a View commit details
    Browse the repository at this point in the history

  5. Add code to persist payments after failed payments. The state machine 

    rollbacks the transactions, with this we keep record of what went wrong.
    @luisramos0
    luisramos0 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    734fce5 View commit details
    Browse the repository at this point in the history

  6. Rename AdvanceOrderService to OrderWorkflow

    @luisramos0
    luisramos0 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    26eee46 View commit details
    Browse the repository at this point in the history

  7. Move advance_order_state from checkout_controller to OrderWorkflow se… 

    …rvice
    @luisramos0
    luisramos0 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    c3f9905 View commit details
    Browse the repository at this point in the history

  8. Move shipping method id setting code to OrderWorkflow service

    @luisramos0
    luisramos0 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    9cbcf14 View commit details
    Browse the repository at this point in the history

  9. Refactor OrderWorkflow

    @luisramos0
    luisramos0 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    ac5882e View commit details
    Browse the repository at this point in the history

  10. Move payments persistence code to order workflow service

    @luisramos0
    luisramos0 committed Jul 28, 2020
    1 Configuration menu
    Copy the full SHA
    0700559 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2020

  1. Complete renaming of AdvanceOrderService to OrderWorkflow

    @mkllnk
    mkllnk committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    fe0c04b View commit details
    Browse the repository at this point in the history

  2. Improve readability and add bugsnag error (now in the checkout_failed… 

    … method) when checkout_fails while handling stripe redirect
    @luisramos0
    luisramos0 committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    ad00971 View commit details
    Browse the repository at this point in the history

  3. Add a comment to explain the necessity of the first rescue in the upd… 

    …ate action
    @luisramos0
    luisramos0 committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    da4abf6 View commit details
    Browse the repository at this point in the history

  4. Remove rescue_from and just add the rescue to the edit action, the up… 

    …date action has a different logic where there is a generic rescue StandardError after the GatewayError rescue
    @luisramos0
    luisramos0 committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    9e9e0d0 View commit details
    Browse the repository at this point in the history

  5. Avoid reloading the payment every time, so that in-memory data is not… 

    … wiped out

When checkout fails and the payment states dont match (inside the if), in-memory data of the failed payment can be lost but updating the payment state is the fundamental part here so that further checkout attempts work. We may improve this update statement so that all the data of the failed payment is persisted
    @luisramos0
    luisramos0 committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    2136eec View commit details
    Browse the repository at this point in the history

  6. Add specs to verify that Spree::Core::Gateway exceptions are handled … 

    …correctly
    @luisramos0
    luisramos0 committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    e739c51 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Improve code comments on dodgy and/but critical checkout process method

    @luisramos0
    luisramos0 committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    0359d10 View commit details
    Browse the repository at this point in the history