Clean up AuthenticationWorkflow spec helper #5828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
force-pushed
the
ent_user
branch
2 times, most recently
from
34e8a00
to
b111b5b
Compare
…gin_as_enterprise_user
luisramos0
force-pushed
the
ent_user
branch
2 times, most recently
from
66f08ab
to
520c6b7
Compare
…unnecessarily This commit removes 19 unnecessary page loads of the admin dashboard
…o_admin_and_visit when applicable
…x rubocop todo files
sauloperez
reviewed
Jul 28, 2020
|
nice, thanks Pau. Can you approve the PR? |
sauloperez
reviewed
Aug 4, 2020
| # # Equivalent to being in spec/controllers | ||
| # end | ||
| config.infer_spec_type_from_file_location! | ||
| end |
There was a problem hiding this comment.
I just noticed this. This block shouldn't be here at all but in spec/spec_helper.rb. I'll patch this myself and it'll be ready to go. The longer we wait the more chances of this PR becoming stale.
Spec files individually include the module and we specify the type of spec in each RSpec's describe so none of this settings are needed. They are just Spree's legacy I bet.
Apparently, although we tend to add the type of spec file some RSpec methods are not working without it. We're getting: ``` NoMethodError: undefined method `helper' for RSpec::ExampleGroups::SpreeSharedOrderDetailsHtmlHaml:Class ``` ``` NameError: undefined local variable or method `controller' for #<RSpec::ExampleGroups::SpreeAdminUsersController::AuthorizeAdmin:0x00007fa8b32addf8> # ./spec/controllers/spree/admin/users_controller_spec.rb:10:in `block (3 levels) in <top (required)>' ``` It needs more investigation but another day.
|
Here comes my hope as a new commit |
|
Green light! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Originated from #5827 I did a few things here:
What should we test?
This is only changing specs, a green build is enough.
Release notes
Changelog Category: Changed
Simplified the code and improved speed of specs.