5579 missing translation subscriptions #5847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fun fact - I've just started a job as a teaching assistant with a non-profit coding boot camp and I did this code change and PR on Zoom with 40+ dev students... |
luisramos0
approved these changes
Jul 31, 2020
sauloperez
approved these changes
Aug 3, 2020
|
thank you @rmklaus12 !! And congrats on your new job 👏 This is ready to go!
|
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Closes #5579
The heading of "Subscriptions" on admin/subscriptions was not being translated.
What should we test?
Go to admin/subscriptions on a non-English instance and verify the heading "Subscriptions" is being translated.
Release notes
Will allow for translation of "Subscriptions" heading
Changelog Category: Added