Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation key 'item', 'qty' #5863

Merged
merged 1 commit into from Aug 7, 2020

Conversation

romale
Copy link
Contributor

@romale romale commented Aug 5, 2020

What? Why?

Closes #[the issue number this PR is related to]

In path '/cart'

image

image

What should we test?

Release notes

Changelog Category: Added | Changed | Deprecated | Removed | Fixed | Security

How is this related to the Spree upgrade?

Discourse thread

Dependencies

Documentation updates

Copy link
Contributor

@luisramos0 luisramos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for doing this @romale

Copy link
Contributor

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romale ! these fixes are specially useful for non-English instances 😍

@RachL RachL self-assigned this Aug 7, 2020
@RachL
Copy link
Contributor

RachL commented Aug 7, 2020

Thank you so much @romale ! This is ready to go :)

image

@RachL RachL removed the pr-staged-es label Aug 7, 2020
@luisramos0 luisramos0 merged commit 04fecca into openfoodfoundation:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants