BugsnagJS checkout errors

[Matt-Yorkley]

Related to #5858

• Updates BugsnagJS to latest major version. This should bring a number of improvements.
• Explicitly notifies Bugsnag on checkout errors instead of throwing unhandled errors

[mkllnk]

Great!

We need to find ways to test these things automatically soon.

[Matt-Yorkley]

I've updated this a bit to include javascript unit tests for the bugsnag calls.

[luisramos0]

Nice one Matt.
Can you use the PR template? I think we need some notes for the tester and a line for the release notes.

[luisramos0]

Actually, let me "request changes" - this needs testing notes.
I am not sure we have bugsnagJS in staging, that will need to be setup, should be easy to do.

[Matt-Yorkley]

It's a tricky one to test. I think it's a dev-test.

• Put a bugsnag API key in application.yml with BUGSNAG_JS_KEY:
• Temporarily change line 8 in app/views/layouts/_bugsnag_js.html.haml so the releaseStage is set to staging
• Create some exceptions in the code to test the responses; an error in checkout_controller.rb is the simple one and then: a handled error in app/assets/javascripts/darkswarm/services/checkout.js.coffee around line 30 and then an unhandled error around line 26...

[mkllnk]

🚀

[luisramos0]

ok, I am testing this.

First a simple server side error to set it up:

development stage works:

[luisramos0]

Testing JS without this PR doesnt get me far. I get Bugsnag object not defined errors.
Anyway I switched to this PR and things look a lot better with the new version and new initializer (the new initializer defines Bugsnag obj, the previous one was definig only the lower case bugsnag object.

With this:

I see this:

With this on the console:

I get this:

BUT with this:

I dont get any alert!

I think things are much better now with this PR.
The error will now be notified for sure with the explicit call.
BUT I think we are not exactly logging all errors to bugsnag yet....

So, I am merging this PR now. But maybe we leave the issue open?