Improve subs logging #5908
Merged
Improve subs logging #5908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why not add a unit test to cover this? It's provided pretty critical to debug subs issues. I think it's worth it. |
sauloperez
added
pr-staged-es
pr-staged-fr
|
This works openfoodnetwork=> select * from versions order by id desc limit 5;
id | item_type | item_id | event | whodunnit | object | created_at | custom_data
-----+------------+---------+---------+-----------+--------------------------------------------------+----------------------------+-------------
655 | Schedule | 13 | create | 1 | | 2020-08-27 14:20:04.590854 | []
654 | OrderCycle | 90 | create | 1 | | 2020-08-27 14:18:25.935542 | []
653 | OrderCycle | 74 | update | | --- +| 2020-08-25 08:38:45.651059 | [12]
| | | | | id: 74 +| |
| | | | | name: OC July +| |
| | | | | orders_open_at: 2020-07-31 22:00:00.000000000 Z +| |
| | | | | orders_close_at: 2020-09-15 22:00:00.000000000 Z+| |
| | | | | coordinator_id: 42 +| |
| | | | | created_at: 2020-06-09 10:36:15.215751000 Z +| |
| | | | | updated_at: 2020-08-25 08:38:30.233154000 Z +| | The row prior to the deploy does not have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Related to #5743
Adds some minor improvements to subs logging, but the problems are not completely resolved yet. See issue notes.
What should we test?
whodunnitfield.Unpermitted attribute: order_cycle_idswarning when creating/updating schedules.Release notes
Improved PaperTrail logging for subscriptions