Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrolling animate on sidebar hide #5910

Conversation

Matt-Yorkley
Copy link
Contributor

What? Why?

Closes #5765

Adds sliding animation on cart sidebar close.

What should we test?

Cart sidebar slides out when closed.

Release notes

Added sliding animation on cart sidebar close

@Matt-Yorkley Matt-Yorkley self-assigned this Aug 17, 2020
@Matt-Yorkley Matt-Yorkley force-pushed the silky-mooth-sidebar-scrolling-for-danni branch from ba923ee to ed346b3 Compare August 17, 2020 12:41
@luisramos0
Copy link
Contributor

Very simple code change, moving to test ready with one approval.

@daniellemoorhead daniellemoorhead self-assigned this Aug 18, 2020
@daniellemoorhead daniellemoorhead added the pr-staged-au staging.openfoodnetwork.org.au label Aug 18, 2020
@daniellemoorhead
Copy link
Contributor

daniellemoorhead commented Aug 18, 2020

Good news: Slides back in now, good job 👍

Bad news: I've noticed strange things happening on desktop and tablet (and mobile but the cart covers the whole screen so not as noticeable) that's also on production.

  • When cart opens on Desktop (Mac/Chrome + Safari and Windows 10/Chrome) the page content jumps a few pixels to the right (on any page) and then when you shut it the page jumps back to the original position.
  • On mobile and tablet the sticky search/filter bar disappears whenever you open the cart. It doesn't disappear when the sticky factor isn't engaged.

I'm going to log bugs for these 2 things to be fixed - yep, they're not critical, but if we're going to implement these design changes then I reckon we should be making it look right the first time around, especially on this outward facing part of the app.

@luisramos0
Copy link
Contributor

@daniellemoorhead from what you write it looks like this PR is ready to go but you havent moved it to Ready to Go. Can I merge?

@luisramos0 luisramos0 merged commit eb2d8e6 into openfoodfoundation:master Aug 19, 2020
@sigmundpetersen sigmundpetersen removed the pr-staged-au staging.openfoodnetwork.org.au label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mobile ux] Close cart dropdown doesn't slide off screen
4 participants