[Bye bye spree] Bring base_helper and log_entry from spree core

[luisramos0]

What? Why?

Continues #4826
Here we move the following files to OFN:

• core/app/helpers/spree/base_helper.rb MERGE WITH DECORATOR
• core/spec/helpers/base_helper_spec.rb MERGE WITH DECORATOR
• core/app/models/spree/log_entry.rb COPY

No code changes were made, here we only move the code from spree, adapt the specs if needed and improve the code a little with rubocop and transpec.

What should we test?

Re Spree::BaseHelper:

• pretty time - make sure a payment date is displayed correctly in the order payments page, like this:
  

re Spree::LogEntry

• make a Stripe payment then run this SQL in the database of the server (replace order number):
  select l.details from spree_orders o, spree_payments p, spree_log_entries l where o.number = 'R820014810' and o.id = p.order_id and p.id = l.source_id;
  There should be some log info about the transaction with Stripe.

Release notes

Changelog Category: Changed
Brought code needed in OFN from Spree so that we can make OFN independent of Spree.

[sauloperez]

Thinking out loud: It would've been much easier not to include this in the same DB transaction so it wouldn't have been rolled back.

[filipefurtad0]

Hi @luisramos0 ,

Before staging this PR, I checked the Payments tab, when editing an order before this PR, for an order with Stripe-SCA payment method:

Then, I ran the SQL command for that order, and got (first lines):

                                                                  details                                                                  
-------------------------------------------------------------------------------------------------------------------------------------------
 --- !ruby/object:ActiveMerchant::Billing::Response                                                                                       +
 params:                                                                                                                                  +
   id: pi_1HRyCNKuuB1fWySnE4Icc45j                                                                                                        +
   object: payment_intent                                                                                                                 +
   allowed_source_types:                                                                                                                  +
   - card                                                                                                                                 +
   amount: 16100                                                                                                                          +
   amount_capturable: 16100                                                                                                               +
   amount_received: 0                                                                                                                     +
   application: ca_9ByaSyyyXj5O73DWisU0KLluf0870Vro                                                                                       +
   application_fee_amount:                                                                                                                +
   canceled_at:                                                                                                                           +
   cancellation_reason:                                                                                                                   +
   capture_method: manual                                               

After that, I staged the PR and

• verified the previously placed order looks as before (Payments tab and SQL output)

• placed a new order, and checked how Payments look like, in the back office:

Then, I ran the SQL command, for that order:

                                                              details                                                                  
-------------------------------------------------------------------------------------------------------------------------------------------
--- !ruby/object:ActiveMerchant::Billing::Response                                                                                       +
params:                                                                                                                                  +
 id: pi_1HRydiKuuB1fWySnsNMjUcob                                                                                                        +
 object: payment_intent                                                                                                                 +
 allowed_source_types:                                                                                                                  +
 - card                                                                                                                                 +
 amount: 16100                                                                                                                          +
 amount_capturable: 16100                                                                                                               +
 amount_received: 0                                                                                                                     +
 application: ca_9ByaSyyyXj5O73DWisU0KLluf0870Vro                                                                                       +
 application_fee_amount:                                                                                                                +
 canceled_at:                                                                                                                           +
 cancellation_reason:                                                                                                                   +

All good!
Ready to go.