Customer totals fee calculations #5931
Conversation
Matt-Yorkley
force-pushed
the
customer-totals-fees
branch
from
308dc3a
to
d91ed54
Compare
…garded as applied to an order. When an order is submitted and the payment fails, the failed payment's adjustments (payment fees) are set to `eligible: false` to indicate they do not apply. These should not be counted as being included in an order's adjustments.
Matt-Yorkley
force-pushed
the
customer-totals-fees
branch
from
d91ed54
to
3badaa0
Compare
|
Hey @Matt-Yorkley , I think I've managed to reproduce this. The numbers 36 (6 attempts) and 30 (6 attempts) are seen in the report below, from repeated attempts to pay with a transaction fee of 6 pounds, for orders with 1 item:
This is seen both in orders placed in the front and back office. After staging the PR, and re-attempting to pay with invalid cards (before finishing the order with a valid payment) does not result in charging the transaction fee multiple times. Furthermore, this PR seems to correct the previously incorrect reports - this is great news! It would be great to check in production... Pinging @emilyjeanrogers here as well. See the report below (after staging the PR), in which the previously placed orders (1 item) now have the correct amounts charged (6 pounds). The orders placed after staging the PR contain 10 items in the cart. All orders have the same transaction fee, despite multiple payment failed attempts:
Awesome Matt! |
What? Why?
Closes #5915
Adjusts displayed payment fees to only sum "eligible" fees, which excludes adjustments on failed payments.
What should we test?
Payment and shipping fees are correct in customer Totals report. Check and order with payment fees applied, which has both a failed payment and a completed payment. The value should not include the fees for the failed payment.
Release notes
Fixed payment fee display in Customer Totals report.