Fix master build - fix mail interceptor spec #5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was due to an incompatibility between two recent PRs: 5763 and 5733. PR 5733 did not take into account 5763 (the confirm email method was removed) and so the specs introduced were broken.
Merged
luisramos0
changed the title
Matt-Yorkley
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This fixes an incompatibility between two recent PRs: #5763 and #5762
PR #5733 did not take into account #5763 (where the Spree::OrderMailer#confirm_email method was removed) and so the mail_interceptor_spec (that used Spree::OrderMailer.confirm_email) introduced in #5733 was breaking.
Here we switch the mail_interceptor_spec to use Spree::OrderMailer.confirm_email_for_shop instead.
What should we test?
Green build is enough.
Release notes
Changelog Category: Fixed
Fix spec incompatibility between two parallel PRs.