[Bye bye Spree] Make OFN independent of spec helpers under core/lib/testing_support #5941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
force-pushed
the
no_spree_specs
branch
from
8cc7abe
to
78a6674
Compare
…18n_translations_checker
luisramos0
force-pushed
the
no_spree_specs
branch
from
acaf963
to
b227c78
Compare
luisramos0
changed the title
sauloperez
reviewed
Aug 26, 2020
…d remove select2_search and dependent code
sauloperez
approved these changes
Aug 27, 2020
|
This is pretty simple and hardly matter of discussion so I'm moving forward and merging for the sake of the pipe. |
Matt-Yorkley
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Here we move some required helpers from spree_core: testing_support/i18n, preferences helper and some methods from capabara_ext into WebHelper.
This makes OFN independent of all helpers under core/lib/testing_support
The only remaining needed files there are the factories, will be addressed in a separate PR.
What should we test?
Only test code changed, a green build is enough.
Release notes
Changelog Category: Changed
Updated test code to be independent of spree test helpers so we can make OFN independent of Spree.