New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing translation key en.spree.activerecord.models.spree/payment.one #5944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for another useful contribution @romale !
@@ -3635,3 +3635,7 @@ See the %{link} to find out more about %{sitename}'s features and to start using | |||
shipment: | |||
cannot_ready: "Cannot ready shipment." | |||
invalid_taxonomy_id: "Invalid taxonomy id." | |||
activerecord: | |||
models: | |||
spree/payment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this key is already defined at line 35 so you should append one
there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on line 35, 'spree/payment' is under 'activerecord.attributes', but in my case under 'activerecord.models'. Or does it not matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. Good catch. I find it a bit odd but if it works 👍
@@ -3635,3 +3635,7 @@ See the %{link} to find out more about %{sitename}'s features and to start using | |||
shipment: | |||
cannot_ready: "Cannot ready shipment." | |||
invalid_taxonomy_id: "Invalid taxonomy id." | |||
activerecord: | |||
models: | |||
spree/payment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right. Good catch. I find it a bit odd but if it works 👍
Hey @romale , I hope to have spotted exactly the bit which now should be translated in production - the page looks good: Looks ready to be merged, moving to ready to go. Thank you for contributing! |
there will be others, I haven't finished translating the UG yet :)) |
My mistake. This should read as "Payment" and not "One". |
My mistake as well - I completely missed that... |
In path: /admin/orders/R445126588/payments/21
OFN 3.2.3
Firefox Desktop
What should we test?
Release notes
Changelog Category: Added | Changed | Deprecated | Removed | Fixed | Security
Discourse thread
Dependencies
Documentation updates