Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation key en.spree.activerecord.models.spree/payment.one #5944

Merged
merged 1 commit into from Aug 27, 2020

Conversation

romale
Copy link
Contributor

@romale romale commented Aug 24, 2020

In path: /admin/orders/R445126588/payments/21

image

OFN 3.2.3
Firefox Desktop

What should we test?

Release notes

Changelog Category: Added | Changed | Deprecated | Removed | Fixed | Security

Discourse thread

Dependencies

Documentation updates

Copy link
Contributor

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for another useful contribution @romale !

@@ -3635,3 +3635,7 @@ See the %{link} to find out more about %{sitename}'s features and to start using
shipment:
cannot_ready: "Cannot ready shipment."
invalid_taxonomy_id: "Invalid taxonomy id."
activerecord:
models:
spree/payment:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this key is already defined at line 35 so you should append one there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on line 35, 'spree/payment' is under 'activerecord.attributes', but in my case under 'activerecord.models'. Or does it not matter?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. Good catch. I find it a bit odd but if it works 👍

@@ -3635,3 +3635,7 @@ See the %{link} to find out more about %{sitename}'s features and to start using
shipment:
cannot_ready: "Cannot ready shipment."
invalid_taxonomy_id: "Invalid taxonomy id."
activerecord:
models:
spree/payment:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. Good catch. I find it a bit odd but if it works 👍

@filipefurtad0 filipefurtad0 self-assigned this Aug 27, 2020
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Aug 27, 2020
@filipefurtad0
Copy link
Contributor

Hey @romale ,

I hope to have spotted exactly the bit which now should be translated in production - the page looks good:
image

Looks ready to be merged, moving to ready to go.

Thank you for contributing!

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Aug 27, 2020
@romale
Copy link
Contributor Author

romale commented Aug 27, 2020

there will be others, I haven't finished translating the UG yet :))

@mkllnk mkllnk merged commit 2a71af7 into openfoodfoundation:master Aug 27, 2020
@sauloperez
Copy link
Contributor

My mistake. This should read as "Payment" and not "One".

@filipefurtad0
Copy link
Contributor

My mistake as well - I completely missed that...
I see this should be fixed by #5963 . Thanks @sauloperez .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants