Do not require view overrides

[sauloperez]

What? Why?

View overrides were removed long ago, so no need to require an empty list.

The next step will be class decorators.

What should we test?

A green build is enough.

Release notes

Do not require long gone view overrides
Changelog Category: Removed

[luisramos0]

😍 I spotted that one yesterday working on bye bye spree.

[sauloperez]

I'll cede the removal of the decorators to you, as a humble recognition 😂

[luisramos0]

ehehe :-D
There are decorators in spree_paypal_express, so I think we will have that in here for while. Even after spree_core is gone.

[sauloperez]

any reason why we couldn't bring in spree_paypal_express? We're maintaining our own fork anyway.

[luisramos0]

I like it to be a separate gem actually! Paypal is really an addon. Maybe we can do the opposite in this case and move what's in the decorator to the gem?

[sauloperez]

IMO having it in the same codebase would make it much easier to deal with such an updated integration. Remember we went through this summer. A separate gem makes sense for a product like Spree but I'm not that sure for something like OFN after Spree is merged in.

[luisramos0]

yeah, it's debatable. Spree is a heavily customized core dependency, doesnt make sense to have it externalized 👍 Paypal is totally different case, I think it's ok to have it as a gem. I am ok with merging it to ofn. But only if integrated in a specific engine, I'd even prefer to have an engine only for it.

[sauloperez]

makes sense in an engine, def.