Fix embedded shops failing javascript because jQuery is try to be accessed before being loaded #5996
Conversation
accessed before being loaded Show we check for $.ready when jQuery is not downloaded yet in the browser. The solution is to check if document is ready with plain DOM javascript event `DOMContentLoaded`
There was a problem hiding this comment.
Nice one! nothing beats having a seasoned frontend dev around 😂 💪 Thanks again @andresgutgon !
filipefurtad0
added
pr-staged-uk
|
Hey @andresgutgon , Using Chrome browser, I verified the console error on the page biodynamic.org.uk/where-to-buy and that zoom commands are missing from the embedded map (pic below, left side.) However, after staging, I'm observing the same error, zoom buttons absent as well (pic below, right side). Also, one sees a violation concerning
Maybe this PR needs a second look? What do you think @Matt-Yorkley @sauloperez? |
|
Hi @filipefurtad0 it's staging public? Can I check it? |
|
This was incorrect thinking from my side: I staged the PR on a staging server, but this of course will not address the issue on the website - as this is in production. So, coming to think of it @andresgutgon , this is actually a production test, right? The only valuable test I think of in staging would be to embed a shop from a staging server in a website, and i) verify the bug and then ii) see its good after the PR. Maybe we should just go ahead and merge, to check it on the next release? Thoughts? |
|
Hmm, embed shopfronts is an unsupported feature now. This is going to be merged and disappear from the pipe (usually the tag prod-test remains on the open issue, not the PR), so we need to remember to test this in prod after the release on Tuesday. |
|
I see we have issue #2723 for this. We dont need to remember the prod-test here. I added the label to #2723 and left it in Test Ready 👍 |
andresgutgon
deleted the
fix/iframe-shop-failing-because-jquery-is-not-loaded
branch
|
Hi @andresgutgon , The code from this PR is in production. Visiting the page biodynamic.org.uk/where-to-buy and opening the Chrome console shows that the
What do you think? |
|
What I think is that life is hard 😂 I may take another look. At least I think we solved an error here right? I guess, not sure let's see |
|
Yeah, the original error seems to be gone 👍 Thank you @andresgutgon! |
What? Why?
We check for
$(document).readywhen jQuery is not downloaded yet in the browser. The solution is to check if document is ready with plain DOM javascript eventDOMContentLoadedThis is the error in a client's page biodynamic.org.uk/where-to-buy when embedding the map:
Closes #2723 (Maybe, I'm not sure)
What should we test?
After deployed the change check browser console on this page biodynamic.org.uk/where-to-buy and also check the issue. No Zoom Buttons on Maps in Embedded Groups
Changelog Category: Fixed