Fix module declaration #6010
Merged
Fix module declaration #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running script/prepare_imported_db.rb failed because Spree::PaymentMethodDistributors couldn't be found. This problem is described in the Rubocop docs: https://rubystyle.guide/#namespace-definition
sauloperez
approved these changes
Sep 10, 2020
luisramos0
approved these changes
Sep 10, 2020
|
yes, I had my doubts too @luisramos0 but the fact that this DB script fails and tests pass... 🤷 |
|
Okay, I skipped the testing because it will be covered by the release test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Running script/prepare_imported_db.rb failed because Spree::PaymentMethodDistributors couldn't be found. This problem is described in the Rubocop docs: https://rubystyle.guide/#namespace-definition
I fixed only two files. There are 64 more files that don't declare the namespace correctly but they haven't been a problem so far. That's still tech debt.
What should we test?
Release notes
Fixed database import script for developers.
Changelog Category: Fixed