Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #6252 ([mobile UX] Eur symbol displayed below the price of the item) #6383

Merged
merged 4 commits into from
Dec 2, 2020
Merged

fix #6252 ([mobile UX] Eur symbol displayed below the price of the item) #6383

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2531136
fix #6252
andrewpbrett Nov 16, 2020
b2fafa5
fix currency spec
andrewpbrett Nov 16, 2020
95d48d8
use white-space: nowrap on variant prices
andrewpbrett Nov 29, 2020
85b143b
rearrange css
andrewpbrett Nov 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/javascripts/darkswarm/filters/localize_currency.js.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Darkswarm.filter "localizeCurrency", (currencyConfig)->
# Set decimal points, 2 or 0 if hide_cents.
decimals = if currencyConfig.hide_cents == "true" then 0 else 2
# Set format if the currency symbol should come after the number, otherwise (default) use the locale setting.
format = if currencyConfig.symbol_position == "after" then "%n %u" else undefined
format = if currencyConfig.symbol_position == "after" then "%n%u" else undefined
andrewpbrett marked this conversation as resolved.
Show resolved Hide resolved
andrewpbrett marked this conversation as resolved.
Show resolved Hide resolved
# We need to use parseFloat as the amount should come in as a string.
amount = parseFloat(amount)

Expand Down
2 changes: 1 addition & 1 deletion spec/javascripts/unit/darkswarm/filters/localize_currency_spec.js.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe 'convert number to localised currency ', ->

it "can place symbols after the amount", ->
currencyconfig.symbol_position = "after"
expect(filter(333.3)).toEqual "333.30 $"
expect(filter(333.3)).toEqual "333.30$"

it "can add a currency string", ->
currencyconfig.display_currency = "true"
Expand Down