Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment flaky (?) spec #7788

Conversation

jibees
Copy link
Contributor

@jibees jibees commented Jun 15, 2021

What? Why?

The test was commented through the commit: eb4d648

Closes #5735

What should we test?

Green build 🟢

Release notes

Changelog Category: Technical changes

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #7788 (9cf10de) into master (d839313) will decrease coverage by 8.18%.
The diff coverage is n/a.

❗ Current head 9cf10de differs from pull request most recent head 7f5e58b. Consider uploading reports for the commit 7f5e58b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7788      +/-   ##
==========================================
- Coverage   93.35%   85.17%   -8.19%     
==========================================
  Files         636      636              
  Lines       18129    18534     +405     
==========================================
- Hits        16925    15787    -1138     
- Misses       1204     2747    +1543     
Impacted Files Coverage Δ
app/controllers/map_controller.rb 0.00% <0.00%> (-100.00%) ⬇️
app/services/sets/enterprise_fee_set.rb 0.00% <0.00%> (-100.00%) ⬇️
app/services/sets/column_preference_set.rb 0.00% <0.00%> (-100.00%) ⬇️
app/controllers/api/v0/states_controller.rb 0.00% <0.00%> (-100.00%) ⬇️
app/serializers/api/adjustment_serializer.rb 0.00% <0.00%> (-100.00%) ⬇️
app/controllers/api/v0/statuses_controller.rb 0.00% <0.00%> (-100.00%) ⬇️
app/controllers/stripe/webhooks_controller.rb 0.00% <0.00%> (-100.00%) ⬇️
app/controllers/stripe/callbacks_controller.rb 0.00% <0.00%> (-100.00%) ⬇️
app/serializers/api/taxon_jstree_serializer.rb 0.00% <0.00%> (-100.00%) ⬇️
app/controllers/api/v0/taxonomies_controller.rb 0.00% <0.00%> (-100.00%) ⬇️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d839313...7f5e58b. Read the comment docs.

@sauloperez
Copy link
Contributor

I just re-run the build to see if it's always passing. I wonder, however, what we did for it to pass now.

@jibees
Copy link
Contributor Author

jibees commented Jun 17, 2021

@sauloperez

I just re-run the build

I re-run several times too. One things we've done is to escape from semaphore and go into GH Actions. Maybe it could explain (not very satisfying explanation I know)

@andrewpbrett andrewpbrett merged commit 355b5ab into openfoodfoundation:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky spec] spec/models/variant_override_spec.rb:36
3 participants