Bugfix ofxSliderGroup division by zero (#6034)

openframeworks · Jul 30, 2018 · 659cc30 · 659cc30
1 parent 81245d2
commit 659cc30
Showing 1 changed file with 18 additions and 3 deletions.
diff --git a/addons/ofxGui/src/ofxSliderGroup.cpp b/addons/ofxGui/src/ofxSliderGroup.cpp
@@ -143,7 +143,12 @@ ofxColorSlider_<ColorType> * ofxColorSlider_<ColorType>::setup(ofParameter<ofCol
         add(new ofxSlider<ColorType>(p, width, height));
         p.addListener(this, & ofxColorSlider_::changeSlider);
 		collection[i]->setFillColor(value.get());
-		collection[i]->setTextColor(p / p.getMax() > 0.75 ? ofFloatColor(0.) : ofFloatColor(1.));
+        float range = p.getMax()-p.getMin();
+        if(range == 0){
+            collection[i]->setTextColor( ofFloatColor(0.));
+        }else{
+            collection[i]->setTextColor( p/range > 0.75 ? ofFloatColor(0.) : ofFloatColor(1.));
+        }
     }
 	add(&picker);
 	picker.getParameter().template cast<ofColor_<ColorType>>().addListener(this, & ofxColorSlider_::changeValue);
@@ -174,7 +179,12 @@ void ofxColorSlider_<ColorType>::changeSlider(const void * parameter, ColorType
     for (int i=0; i<4; i++){
 		collection[i]->setFillColor(data);
 		auto p = parameters[i].template cast<ColorType>();
-		collection[i]->setTextColor(p / p.getMax() > 0.75 ? ofFloatColor(0.) : ofFloatColor(1.));
+        float range = p.getMax()-p.getMin();
+        if(range == 0){
+            collection[i]->setTextColor( ofFloatColor(0.));
+        }else{
+            collection[i]->setTextColor( p/range > 0.75 ? ofFloatColor(0.) : ofFloatColor(1.));
+        }
 	}
     sliderChanging = false;
 }
@@ -188,7 +198,12 @@ void ofxColorSlider_<ColorType>::changeValue(ofColor_<ColorType> & value){
         parameters[i].template cast<ColorType>() = value[i];
     	collection[i]->setFillColor(value);
 		auto p = parameters[i].template cast<ColorType>();
-		collection[i]->setTextColor(p / p.getMax() > 0.75 ? ofFloatColor(0.) : ofFloatColor(1.));
+        float range = p.getMax()-p.getMin();
+        if(range == 0){
+            collection[i]->setTextColor( ofFloatColor(0.));
+        }else{
+            collection[i]->setTextColor( p/range > 0.75 ? ofFloatColor(0.) : ofFloatColor(1.));
+        }
 	}
 }