Skip to content

Commit

Permalink
Fix compilation on Xcode 10 (#6131)
Browse files Browse the repository at this point in the history 
* Remove the i386 architecture

The i386 architecture is no longer supported in xCode 10

* Remove the QuickTime framework

The QuickTime framework is no longer available in xCode 10. Using it will cause a linker error. I have tested `ofAudioPlayer`, `ofVideoPlayer` and `ofVideoGrabber` and they all work as expected when building without QuickTime.
  • Loading branch information
@kkirby @arturoc
kkirby authored and arturoc committed Sep 23, 2018
1 parent 06bea48 commit da6929b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions libs/openFrameworksCompiled/project/osx/CoreOF.xcconfig
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARCHS = $(ARCHS_STANDARD_32_64_BIT) // this allows you to select target architecture in dropdown menu
VALID_ARCHS = x86_64 i386
VALID_ARCHS = x86_64

ONLY_ACTIVE_ARCH = YES // this makes sure not to build an universal binary

Expand Down Expand Up @@ -55,4 +55,4 @@ OF_CORE_LIBS = $(LIB_TESS) $(LIB_GLEW) $(LIB_CAIRO1) $(LIB_CAIRO2) $(LIB_CAIRO3)
OF_CORE_HEADERS = $(HEADER_OF) $(HEADER_FREETYPE) $(HEADER_FREETYPE2) $(HEADER_FMODEX) $(HEADER_GLEW) $(HEADER_FREEIMAGE) $(HEADER_TESS2) $(HEADER_CAIRO) $(HEADER_RTAUDIO) $(HEADER_GLFW) $(HEADER_BOOST) $(HEADER_UTF8) $(HEADER_JSON) $(HEADER_GLM) $(HEADER_CURL) $(HEADER_URIPARSER) $(HEADER_PUGIXML)


OF_CORE_FRAMEWORKS = -framework Accelerate -framework AGL -framework AppKit -framework ApplicationServices -framework AudioToolbox -framework AVFoundation -framework Cocoa -framework CoreAudio -framework CoreFoundation -framework CoreMedia -framework CoreServices -framework CoreVideo -framework IOKit -framework OpenGL -framework QuartzCore -framework QuickTime -framework QTKit -framework Security -framework LDAP
OF_CORE_FRAMEWORKS = -framework Accelerate -framework AGL -framework AppKit -framework ApplicationServices -framework AudioToolbox -framework AVFoundation -framework Cocoa -framework CoreAudio -framework CoreFoundation -framework CoreMedia -framework CoreServices -framework CoreVideo -framework IOKit -framework OpenGL -framework QuartzCore -framework QTKit -framework Security -framework LDAP

6 comments on commit da6929b

@zachkrall
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ✨

@mamoruwatanabe
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johanGelinder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, Thanks!

@StudioAlbert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fantastic !

@haotian21
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, where exactly is this file? Can´t find this file anywhere... anyone can help? thanks a lot

@ofTheo
Copy link
Member

@ofTheo ofTheo commented on da6929b Feb 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi it is in:
libs/openFrameworksCompiled/project/osx/CoreOF.xcconfig

However the nightly releases at the bottom of: https://openframeworks.cc/download/
Should be Xcode 10/11 compatible and probably won't need any changes.

Please sign in to comment.