Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projectGenerator does not build on vs2010 #1327

Closed
kylemcdonald opened this issue Jun 13, 2012 · 7 comments
Closed

projectGenerator does not build on vs2010 #1327

kylemcdonald opened this issue Jun 13, 2012 · 7 comments

Comments

@kylemcdonald
Copy link
Contributor

perhaps i'm doing something wrong? trying to build the pg gives the following errors: http://pastebin.com/QFpKzksk

it looks like it's all about __dynamic_cast_tag and ofPtr

it looks like this commit by @tgfrerer broke vs2010 7712377

@arturoc
Copy link
Member

arturoc commented Jun 13, 2012

this comes from a PR i merged some days ago: #1313

@tgfrerer can you take a look? i think it's probably related with the fact that vs2010 already uses the c++11 implementation not the tr1 so probably something different has to be done?

@kylemcdonald
Copy link
Contributor Author

also, for anyone hacking on this right now, it's possible to just comment out that chunk of code referring to tr1 and then the PG will compile OK.

@ofTheo
Copy link
Member

ofTheo commented Jun 13, 2012

that was a recent PR closed by @arturoc
#1313

On Jun 13, 2012, at 4:14 PM, Kyle McDonald wrote:

perhaps i'm doing something wrong? trying to build the pg gives the following errors: http://pastebin.com/QFpKzksk

it looks like it's all about __dynamic_cast_tag and ofPtr


Reply to this email directly or view it on GitHub:
#1327

@tgfrerer
Copy link
Member

Auweh! my bad, sorry.

it seems to boil down to "__dynamic_cast_tag' : not being in the namespace of std::tr1 in visual studio's implementation of std::tr1

I assumed that std::tr1 looked the same on Windows/VS as it would on linux / os x, where I tested. I don't have a windows box to dig into the visual studio header files, sadly. I should have tested on Windows though, since it's such a low-level element of the system, sorry.

Let's revoke that pull request / remove that addition for now?

@gameoverhack
Copy link
Contributor

Proposed fix: #1341

This compiles but i'm not sure what the original was doing, so i'm entirely sure that this is doing the same thing...but looks likely

@tgfrerer
Copy link
Member

@gameoverhack both "__dynamic_cast_tag" and "_Dynamic_tag" are afik used as flags, so that should work fine.

I'm a bit worried that I couldn't find a standard (and possibly more future-proof) implementation of dynamic_pointer_cast.

@kylemcdonald
Copy link
Contributor Author

closed by PR #1341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants