ofSystem with Poco::Process.

[diasbruno]

i'm writing an app with a node.js backend, so i'm using a lot ofSystem. the current implementation seems to be inconsistent. with Poco::Process, it works fine.

the new ofSystem would be something like this.

// like 'ofFileDialogResult'.
class ofSystemResult {
public:
    ofSystemResult();

    string result;
    int exit_code;      
};

ofSystemResult ofSystem( string cmd, ofSystemArgs& args );

[bilderbuchi]

I'm not exactly sure what this is about - @kylemcdonald @arturoc @ofTheo could you take a look?

[ofTheo]

the PR #2164 attached to this looks good to me.
its nice that you can get back the output of the system command.
+1 once its been updated with develop

[bilderbuchi]

@ofTheo the PR should already be up to date with develop, don't let yourself be mislead by the merge status warning - that Travis message is from the CI/unit tests that @diasbruno is running with his copy of OF.

[arturoc]

only thing i would change is the second parameter to be something that it's not Poco dependent, can we pass an array of strings or something similar? we can even inherit or typedef from the poco class

[diasbruno]

yep @arturoc. i forgot to change it.

typedef Poco::Process::Args ofSystemArgs. (std::vector).

[arturoc]

yes, if you can change that i think it's good to merge

[diasbruno]

the PR has the type definition.

i forget to change code in the description. :)

[bakercp]

Hi all, I'm not sure what happened here -- it seems the PR was closed?

#2164

We need this to be fixed for ofSketch because ofSystem doesn't work correctly on Raspberry pi (ofGetTargetSystem()) olab-io/ofSketch#58.

I'm happy to pull apart the old PR and resubmit it -- unless @diasbruno has a clean PR to submit.

[bakercp]

Closing this, as Poco is no longer part of the core. If there is a discussion of a non-Poco way to implement it, then let's reopen because the need is probably still there.