Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ofLight.enable calls ofEnableLighting, disable does not ofDisableLighting... #2811

Closed
vade opened this issue Feb 13, 2014 · 1 comment
Closed

ofLight.enable calls ofEnableLighting, disable does not ofDisableLighting... #2811

vade opened this issue Feb 13, 2014 · 1 comment

Comments

@vade
Copy link
Contributor

vade commented Feb 13, 2014

ofLight.enable() calls ofEnableLighting(), butofLight.disable() does not call ofDisableLighting(), which seems counter intuitive to me, as it means disabling a light, but then drawing additional geometry you don't want lit, requires a manual ofDisableLighting() call, even if you .. just disabled your light?

For sanity / completeness and grammar, I think this is a bug.
@vade
Copy link
Contributor Author

vade commented Feb 13, 2014

Im an idiot, if you push / pop lights they'd disable one another. You'd have to manage state to fix this. Ugh. Stylistically this drives me nuts, but yea, that was dumb.

@vade vade closed this as completed Feb 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vade