Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projectgenerator ios - overwrites ios icons/images on project update. #4137

Closed
bakercp opened this issue Jul 24, 2015 · 4 comments
Closed

Projectgenerator ios - overwrites ios icons/images on project update. #4137

bakercp opened this issue Jul 24, 2015 · 4 comments
Assignees
@danoli3
Labels
bug core project-generator
Milestone
0.9.1

Comments

@bakercp
Copy link
Member

bakercp commented Jul 24, 2015

Overwrites all icons with names:

Default-568h@2x~iphone.png
Default.png
Default@2x.png
Default@2x~ipad.png
Default@2x~iphone.png
Default~ipad.png
Default~iphone.png
Icon-72.png
Icon-72@2x.png
Icon.png
Icon@2x.png

This makes sad if one didn't duplicate and save all customized icons before updating the project files ... :(
@bakercp bakercp changed the title Projectgenerator ios - overwrites icons on project update. Projectgenerator ios - overwrites ios icons/images on project update. Jul 24, 2015
@ofZach
Copy link
Contributor

ofZach commented Jul 24, 2015

relevant lines if you want to add a fix, such as checking if files exists and not overwriting, etc:

https://github.com/openframeworks/openFrameworks/blob/master/addons/ofxProjectGenerator/src/projects/xcodeProject.cpp#L277-L287

@bakercp
Copy link
Member Author

bakercp commented Jul 24, 2015

@ofZach thx. Will do.

@arturoc arturoc added this to the 0.9.1 milestone Nov 9, 2015
@danoli3
Copy link
Member

danoli3 commented Dec 15, 2015

I'll fix this up @bakercp

@danoli3 danoli3 self-assigned this Dec 15, 2015
@danoli3 danoli3 mentioned this issue Dec 15, 2015
Merged
@danoli3
Copy link
Member

danoli3 commented Dec 15, 2015

Okay fixed! openframeworks/projectGenerator#100

@danoli3 danoli3 closed this as completed Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danoli3 danoli3

Labels
bug core project-generator
Projects
None yet
Milestone
0.9.1
Development

No branches or pull requests
5 participants
@arturoc @ofZach @bakercp @bilderbuchi @danoli3