Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ofSerial isInitialized( ) #1894

Merged
merged 3 commits into from Feb 27, 2013
Merged

add ofSerial isInitialized( ) #1894

merged 3 commits into from Feb 27, 2013

Conversation

thiagohersan
Copy link
Contributor

closes #1892

@kylemcdonald
Copy link
Contributor

looks obvious and correct to me.

@thiagohersan
Copy link
Contributor Author

I found a bug in ofSerial::close( ) :

It seems like bInited is only reset to false for TARGET_WIN32.

Can I fix that in this PR as well?

@kylemcdonald
Copy link
Contributor

i'd say go for it, you can also remove // [CHECK] -- anything else need to be reset? while you're at it ;)

@bilderbuchi
Copy link
Member

looks good to me.

kylemcdonald added a commit that referenced this pull request Feb 27, 2013
@kylemcdonald
Merge pull request #1894 from thiagohersan/feature-ofSerial-isInitial…
b925ff2 
…ized

add ofSerial isInitialized( )
@kylemcdonald kylemcdonald merged commit b925ff2 into openframeworks:develop Feb 27, 2013
@NickHardeman NickHardeman mentioned this pull request Mar 6, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thiagohersan @kylemcdonald @bilderbuchi