Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cc.openframeworks.ofapp as identifier on osx #2647

Merged
merged 1 commit into from
Dec 8, 2013

Conversation

admsyn
Copy link
Member

@admsyn admsyn commented Oct 27, 2013

Closes #2644

@kylemcdonald
Copy link
Contributor

i think the "com" refers to the "company" namespace for identifiers, not to the "com" in domain names (which also stands for "company"). just curious if you can point to another case where a similar identifier is used, or if there are any identifier naming guidelines?

@admsyn
Copy link
Member Author

admsyn commented Oct 27, 2013

My understanding is that it's supposed to be a unique identifier, and using your domain is a fairly foolproof way of deriving an identifier that's almost surely unique. That seems to be the gist as per the reverse domain name wikipedia article that @bilderbuchi linked.

To be more pedantic, the identifier should always be something really unique, like net.kylemcdonald.someapp, but if we're going to include one by default cc.openframeworks.ofapp makes by far the most sense to me (as opposed to cc.openframeworks which would imply that it's just "openframeworks" that's running).

@kylemcdonald
Copy link
Contributor

cool :) 👍

@ofZach
Copy link
Contributor

ofZach commented Oct 28, 2013

it's probably not super complicated to modify the plist as part of the project generator process. it would be in https://github.com/ofZach/projectGeneratorSimple/blob/master/src/projects/xcodeProject.cpp#L223-L298 similar to what saveScheme() does (copy file and do find and replace).

@kylemcdonald
Copy link
Contributor

@ofZach the benefit to not modifying it is that stack traces all look the same which helps for searching + reading

@ofZach
Copy link
Contributor

ofZach commented Oct 28, 2013

I see what you mean. I wonder if there's a way to structure it so that the OF core code gets compiled with a common identifier and the app gets a unique identifier?

@admsyn
Copy link
Member Author

admsyn commented Dec 8, 2013

Any objections to me hitting the big green button before 0.8.1? :) We won't have the unique-identifier-via-PG functionality but it's much better than the "obviously a placeholder" thing we have now.

@kylemcdonald
Copy link
Contributor

👍 i'm up for incremental changes, and zach's suggestion can be opened as a new issue and developed in the future.

admsyn added a commit that referenced this pull request Dec 8, 2013
use cc.openframeworks.ofapp as identifier on osx
@admsyn admsyn merged commit 3577b16 into openframeworks:master Dec 8, 2013
@admsyn admsyn deleted the feature-better-osx-identifier branch December 8, 2013 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.yourcompany.openframeworks should be renamed
3 participants