fix critical issue w/ ofVbo shallow copies (custom attributes) #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes an issue where custom vbo attributes (and their buffers) would not be retained whenever the vbo was shallow copied, since the copy constructors would not copy them over from their mom object. * this is might have especially tripped you up when you wanted to create & then store vbos in a c++ vector, since push_back does initialise by copy, and you'd have lost all your attributes upon pushing the new ofVbo to your storage vector... Signed-off-by: tgfrerer <tim@poniesandlight.co.uk>
arturoc
added a commit
that referenced
this pull request
Mar 12, 2014
fix critical issue w/ ofVbo shallow copies (custom attributes)
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note
this is might have especially tripped you up if you wanted to create, and then store vbos with custom attributes in a c++ vector, since push_back() does initialise by copy, and you'd have lost all your attributes upon pushing the new ofVbo to your storage vector...
Signed-off-by: tgfrerer tim@poniesandlight.co.uk