iOS-VideoGrabber Fixes #2947
Merged
iOS-VideoGrabber Fixes #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Fixes for iOS revisions less than 7. -Now builds against SDK levels lower than 7
| @@ -13,6 +13,9 @@ | |||
|
|
|||
| #if defined __arm__ | |||
|
|
|||
| #define IS_IOS_7_OR_LATER ([[[UIDevice currentDevice] systemVersion] floatValue] >= 7.0) | |||
| #define IS_IOS_6_OR_LATER ([[[UIDevice currentDevice] systemVersion] floatValue] >= 6.0) | |||
There was a problem hiding this comment.
I think those preprocessor defines should go in addons/ofxiOS/src/utils/ofxiOSExtras.h, where all the others are.
There was a problem hiding this comment.
AVFoundationVideoGrabber and AVFoundationVideoPlayer should both be OF independent.
AVFoundationVideoGrabber currently is not, but it will be in the future.
currently we have those sort of check all throughout ofxiOS and it definitely needs to be merged into the one place.
ofxiOSExtras is probably the best place for it but currently its a mess and includes every other class in ofxiOS.
i think for now this solution is ok and in the future we can address the ofxiOSExtras issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixes for iOS revisions less than 7.
-Now builds against SDK levels lower than 7
Fixes problems found by @luisgarrido
See #2832 for more info.