Fix get current matrix warnings + allow query current Orientation Matrix #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* invalid matrix state queries will return identity matrix and error message at ofLogWarning Level
* this allows you to calculate the *oriented projection matrix* yourself. Sometimes this is needed, e.g. when you have to transform back from (oriented) screen space to view space.
arturoc
added a commit
that referenced
this pull request
May 5, 2014
Fix get current matrix warnings + allow query current Orientation Matrix
|
thanks! yeah the orientation matrix is not very standard but i see how it can be useful in certain cases |
|
thanks, tim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two matrix stack related commits:
b5cca6f : fixes compiler warnings by adding a default case to getCurrentMatrix, as discussed with @bilderbuchi in 150e197#commitcomment-6204050
e8da01f : extends getCurrentMatrix to allow querying the current orientation matrix stack. I found this extension necessary in a current project where i had to do calculations with current projection matrix but found that because openFrameworks post-applies an orientation matrix to the projection matrix i had no access to the correct, oriented projection matrix my shaders were using.