Fix unhandled matrix enums #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e8da01f.
* extend api, add change log entry
| @@ -141,3 +141,9 @@ void ofBaseVideoPlayer::previousFrame(){ | |||
| // ofLogWarning("ofBaseVideoPlayer") << "getPixelFormat() not implemented"; | |||
| // return OF_PIXELS_RGB; | |||
| //} | |||
|
|
|||
| //--------------------------------------------------------------------------- | |||
| ofMatrix4x4 ofBaseRenderer::getCurrentOrientationMatrix() const { | |||
There was a problem hiding this comment.
any special reason for not making this pure virtual, instead of a warning-only skeleton implementation?
There was a problem hiding this comment.
you mean pure virtual as in
ofMatrix4x4 ofBaseRenderer::getCurrentOrientationMatrix() const = 0; ?
Then we'd have to provide implementations with all renderers, which includes Cairo etc. The way i suggest it here this would function as a reminder for renderers that might want to implement this in the future.
There was a problem hiding this comment.
Yes.
I see, makes sense, thank you.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #2969.