Apothecary: FreeImage 3.16.0 #3143

bakercp · 2014-08-11T20:13:51Z

Update apothecary build scripts and header / static libs for FreeImage 3.16 (the latest tagged version).

Static libs for architectures included:

OSX FAT (32 bit w/ libstdc++ and 64 bit w/ libc++)
iOS FAT (armv7, armv7s, arm64, i386 and x86_64 w/ libc++)
Android - armeabi (@arturoc ?)
Android - armeabi-v7a (@arturoc ?)
Android - x86 (@arturoc ?)
VS
win_cb

The following platforms use pkg-config system libs

Linux (32 bit)
Linux (64 bit)
Linux Armv6l
Linux Armv7l

Notes:

Before committing the FreeImage.h I had to convert the line endings to LF. Apparently it is shipped with CRLF.
Most linux distros seem to currently ship with v 3.15.* Theoretically this shouldn't be a problem, as linux uses pkg-config headers.
On win_cb / vs, we simply download extract and copy the precompiled libs. The same .lib and .dll work on both win_cb and vs, resulting in duplicated files. Using precompiled libs is much simpler than compiling manually w/ mingw, as their toolchain setup is very specific.

ofTheo · 2014-08-11T21:37:14Z

libs/FreeImage/include/FreeImage.h

+typedef uint32_t DWORD;
+typedef int32_t LONG;
+typedef int64_t INT64;
+typedef uint64_t UINT64;


@bakercp - we did this #define approach ( combined with #undefine at the end of the file ) for a while now because MS complains about types being defined already. Its always been a bit of a dirty hack, but it was the only way to get it to compile without errors. did you have a fix for this issue?

I just copied it directly from their source folder -- I didn't realize it was an oF mod. I'm compiling it on win right now (as I type this), so I'll test it and update if the errors come up.

I just tested on both vs2012 and win_cb with the attached static libs / dylibs and updated 3.16.0 header and both linked and compiled fine without any header mods -- so, for the moment, I think I'll leave it as is.

+1 to leave it as-is if it works - patched library files will be a pain to keep up-to-date (as this example shows). If we have to patch them, we should do it in apothecary so at least we can keep track of the changes automatically, and preserve patches across lib updates.

agreed - hopefully it doesn't crop up!
just wanted to make a note of it as it was a common part of the process of updating free image.
we could definitely add it as a patch step to apothecary if needed.

bakercp · 2014-08-11T22:12:22Z

@ofTheo @arturoc Can either of you explain why there are static FreeImage libs in the $OF_ROOT/libs/Freeimage/vs|win_cb dirs and also FreeImage.dll dynamic libs in the export folder? The programs won't run without the dlls, but I'm just wondering why we have both ... I'm quite inexperienced on the windows side (but learning quickly :))

arturoc · 2014-08-12T07:29:10Z

some libraries just do that, if you compile it and don't get a dll then it's fine to remove it from export. there must be a way to avoid it but last time i compiled it i couldn't find it

ofTheo · 2014-08-12T12:21:10Z

@bakercp if FreeImage is build dynamically it needs a stub lib and a dll. the stub lib is a super light lib which tells the compiler to search for those methods on runtime.

I don't know why we have FreeImage as dynamic on windows, it would be great if we could build it statically!

bakercp · 2014-08-12T12:24:33Z

@ofTheo -- ok that makes sense. I'm fairly confident the current FreeImage.lib in this PR is a full static lib (which means we could drop the dll from exports) -- but I'll do a bit more research.

danoli3 · 2014-08-25T15:42:27Z

@bakercp want me to have a look at compiling the iOS FreeImage?

bakercp · 2014-08-25T21:48:34Z

For sure :)

danoli3 · 2014-08-27T01:50:46Z

Just noticed we should be running strip -x $lib.a on the libs.
For example: FreeImage for iOS got up to 130mb fat lib, even with -02 (too big for git)
After running strip on it, it's down to 29mb

Current oF libs up there < 0.8+ have already been stripped of these symbols.

…6, x86_64) - Custom makefile for iOS created to put power of target arch into the Apothecary script and bypass errors - In line hot fixes for arm64 for some of the sub-libraries of FreeImage.

… libc++.

Apothecary: FreeImage iOS Formula + libs

danoli3 · 2014-09-04T04:33:49Z

Okay I found some major issues with LibJXR for OSX / iOS.
May be that symbolic linking errors you were having @bakercp. I've been able to fix it, but with quite extensive patching of LibJXR. I'll work out how to make a patch for it and submit it with an updated script.

Basically without modification the C source files link and predeclare functions that are not within the bounds of the object that is compiled, so predeclaring example_function in abc.c however it is implemented in another c file called abcdef.c. So when it comes to linking the symbols together it can't find that implementation = symbolic issue.

FreeImage should not have included this new lib without testing it! Bad #freeimage ;D

bakercp · 2014-09-04T04:35:30Z

Interesting thanks for sticking with it ...

danoli3 · 2014-09-04T04:45:39Z

It all became apparent when compiling all the libs together.. I think we are still missing the formula for glu as well. Any idea how we compiled this one before?

tgfrerer · 2014-09-04T08:21:23Z

Are you sure are we still using glu? I believe the last hold-out was in texture mipmaps, and that's been taken care of in #3146.

danoli3 · 2014-09-04T08:35:24Z

Ah yes! Awesome, better if it is removed :) I'll try that out.

On 4 September 2014 18:21, Tim Gfrerer notifications@github.com wrote:

Are you sure are we still using glu? I believe the last hold-out was in
texture mipmaps, and that's been taken care of in #3146
#3146.

—
Reply to this email directly or view it on GitHub
#3143 (comment)
.

pizthewiz · 2014-09-08T05:09:47Z

From #2542, @julapy mentioned that PIE needs to be enabled for the iOS formula.

…ks into apothecary-FreeImage

ofTheo · 2014-09-15T13:54:20Z

is it okay to update the list with iOS as done?

danoli3 · 2014-09-15T14:31:03Z

Not finished yet, 90% there. Still have some symbol link errors when
binding, mainly due to some broken third party Microsoft code that
FreeImage added in. Almost fixed all of them.

On 15 September 2014 23:54, Theodore Watson notifications@github.com
wrote:

is it okay to update the list with iOS as done?

—
Reply to this email directly or view it on GitHub
#3143 (comment)
.

…ks into apothecary-FreeImage

danoli3 · 2014-10-07T01:36:49Z

For OSX + Poco Issues. I just noticed __ANSI__ in the build script.

IE:

The name -ansi is, strictly speaking, incorrect; it refers to the 1989 ANSI C standard, but ANSI itself considers that standard to be obsolete; it was replaced by the 1999 ISO C standard (which ANSI officially adopted shortly after it was released) which itself either has been, or soon will be, replaced by the new 2011 ISO C standard. But changing the meaning of the -ansi option would break too many Makefiles and build scripts."

http://stackoverflow.com/questions/10300114/should-i-use-ansi-or-explicit-std-as-compiler-flags

bakercp · 2014-10-07T02:05:19Z

@danoli3 Yeah, that was required (at least at the time) to get it to compile. More here:

http://sourceforge.net/p/freeimage/discussion/36111/thread/a9cc87b6/

And other places as well ..

danoli3 · 2014-10-07T03:19:14Z

I wonder if -D__ANSI__ is the same as -ansi
As the -ansi option is equivalent to -std=c90 and could be causing those ABI/API libc++/libstd++ issues when linked against say Poco, which is definitely libc++.

So if FreeImage was calling say the libpng code from Poco's code, and the FreeImage code was libstd++ and the Poco code calling it was libc++, would definitely explain the error.

Good reference for this issue:
http://stackoverflow.com/questions/17450130/what-is-a-good-way-of-handling-abi-differences-between-libc-and-the-older-libs

- Fixes symbolic linking issues by patching FreeImage (patch sent to FreeImage repo as well). https://github.com/danoli3/FreeImage - Patch danoli3/FreeImage@f069aaefc6724fa9c8065a47000b 31212024e9d6.patch - Fixes broken make file from FreeImage 3.16.0 - Fixes broken clean script from FreeImage 3.16.0 - Architectures arm64, armv7, armv7s, i386, x86_64

- Tested and working

danoli3 · 2014-10-14T14:40:12Z

Okay finally fixed FreeImage for iOS!! Added Pull to @bakercp fork bakercp#15

I've already tested all the libs together now and it's working :D!!
https://github.com/danoli3/openFrameworks/tree/0.9.0-All

Apothecary: FreeImage 3.16.0 Working for iOS/OSX

- Fixes linking errors to ARM achitectures due to ARM Neon

- With ARM Neon Fix

Apothecary: FreeImage 3.16.0 Working for iOS ARM architectures

Apothecary free image

…ks into apothecary-FreeImage

bakercp · 2014-11-24T22:46:45Z

@danoli3 -- can we merge this? It's looking OK from here.

danoli3 · 2014-11-24T23:40:08Z

Yeah this was working great last I tested.
Should we cherry pick out the libraries first?

Still have to remove iOS armv7s from script and rebuild

On Tuesday, November 25, 2014, Christopher Baker notifications@github.com
wrote:

@danoli3 https://github.com/danoli3 -- can we merge this? It's looking
OK from here.

—
Reply to this email directly or view it on GitHub
#3143 (comment)
.

bakercp · 2014-11-25T00:51:16Z

Yeah, if you want to cherry-pick and fix the script for armv7s, that then we can make a clean build like openssl and poco and hopefully get this all merged in the next day or two ...

ofTheo · 2015-02-08T19:03:59Z

I think we can close this now right? now that #3446 has been merged?

admsyn · 2015-03-08T17:49:41Z

Going to close this, as it looks like #3446 has covered it

bakercp added 3 commits August 11, 2014 15:03

Apothecary: FreeImage Formula 3.16.0 OSX 32-libstdc++ / 64-libc++.

41477a8

Add FreeImage 3.16.0 Header

da519e5

FreeImage 3.16.0 Static libs OSX 32-libstdc++ / 64-libc++.

41f4404

bakercp added this to the 0.9.0 milestone Aug 11, 2014

bakercp changed the title ~~Apothecary: FreeImage 3.16.0~~ Apothecary: FreeImage 3.16.0 (In Progress) Aug 11, 2014

bakercp changed the title ~~Apothecary: FreeImage 3.16.0 (In Progress)~~ Apothecary: FreeImage 3.16.0 Aug 11, 2014

bakercp added the apothecary label Aug 11, 2014

bakercp mentioned this pull request Aug 11, 2014

Apothecary: Poco 1.5.3+ #3116

Closed

11 tasks

bakercp added 2 commits August 11, 2014 16:14

Apothecary formula for FreeImage on win32.

9a049f0

Fixed FreeImage formula for win32.

e923727

ofTheo reviewed Aug 11, 2014
View reviewed changes

bakercp added 4 commits August 11, 2014 16:45

Add FreeImage 3.16.0 win_cb static libs.

29323b1

Add FreeImage 3.16.0 vs static libs.

57ecd74

Update to also copy FreeImage dlls to export/

a836345

Update vs and win_cb FreeImage.dll to export directory.

7051493

danoli3 and others added 3 commits August 27, 2014 12:21

Apothecary: Formula FreeImage 3.16.0 for iOS (arm64, arm7, arm7s, i38…

7d35665

…6, x86_64) - Custom makefile for iOS created to put power of target arch into the Apothecary script and bypass errors - In line hot fixes for arm64 for some of the sub-libraries of FreeImage.

FreeImage 3.16.0 Static libs iOS (arm64, armv7, armv7s, i386, x86_64)…

4274801

… libc++.

Merge pull request #10 from danoli3/apothecary-FreeImage

c86fa82

Apothecary: FreeImage iOS Formula + libs

kylemcdonald assigned bakercp Sep 6, 2014

Merge branch 'master' of git://github.com/openframeworks/openFramewor…

573f73c

…ks into apothecary-FreeImage

admsyn mentioned this pull request Sep 8, 2014

64bit / libc++ formulas - check list ( all platforms ) openframeworks/apothecary#39

Closed

50 tasks

Merge branch 'master' of git://github.com/openframeworks/openFramewor…

fb21d49

…ks into apothecary-FreeImage

danoli3 added 2 commits October 15, 2014 01:26

FreeImage 3.16.0 iOS Lib (arm64, armv7, armv7s, i386, x86_64)

8e5124a

- Tested and working

bakercp and others added 8 commits October 14, 2014 17:15

Merge pull request #15 from danoli3/apothecary-FreeImage

01fe923

Apothecary: FreeImage 3.16.0 Working for iOS/OSX

Apothecary Formula: FreeImage 3.16.0 Updated for IOS Neon Fix

4321823

- Fixes linking errors to ARM achitectures due to ARM Neon

FreeImage 3.16.0 iOS Lib (arm64, armv7, armv7s, i386, x86_64) Updated

3f875f3

- With ARM Neon Fix

Merge pull request #17 from danoli3/apothecary-FreeImage

84c72aa

Apothecary: FreeImage 3.16.0 Working for iOS ARM architectures

Merge branch 'master' into apothecary-FreeImage

10657bb

apothecary: Freeimage android

edc3c9c

Merge pull request #19 from arturoc/apothecary-FreeImage

bb975eb

Apothecary free image

Merge branch 'master' of git://github.com/openframeworks/openFramewor…

6facc30

…ks into apothecary-FreeImage

danoli3 mentioned this pull request Nov 25, 2014

Apothecary - FreeImage 3.16.0 - Formulae #3446

Merged

7 tasks

admsyn closed this Mar 8, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apothecary: FreeImage 3.16.0 #3143

Apothecary: FreeImage 3.16.0 #3143

bakercp commented Aug 11, 2014

ofTheo Aug 11, 2014

bakercp Aug 11, 2014

bakercp Aug 11, 2014

bilderbuchi Aug 12, 2014

ofTheo Aug 12, 2014

bakercp commented Aug 11, 2014

arturoc commented Aug 12, 2014

ofTheo commented Aug 12, 2014

bakercp commented Aug 12, 2014

danoli3 commented Aug 25, 2014

bakercp commented Aug 25, 2014

danoli3 commented Aug 27, 2014

danoli3 commented Sep 4, 2014

bakercp commented Sep 4, 2014

danoli3 commented Sep 4, 2014

tgfrerer commented Sep 4, 2014

danoli3 commented Sep 4, 2014

pizthewiz commented Sep 8, 2014

ofTheo commented Sep 15, 2014

danoli3 commented Sep 15, 2014

danoli3 commented Oct 7, 2014

bakercp commented Oct 7, 2014

danoli3 commented Oct 7, 2014

danoli3 commented Oct 14, 2014

bakercp commented Nov 24, 2014

danoli3 commented Nov 24, 2014

bakercp commented Nov 25, 2014

ofTheo commented Feb 8, 2015

admsyn commented Mar 8, 2015

Apothecary: FreeImage 3.16.0 #3143

Apothecary: FreeImage 3.16.0 #3143

Conversation

bakercp commented Aug 11, 2014

ofTheo Aug 11, 2014

Choose a reason for hiding this comment

bakercp Aug 11, 2014

Choose a reason for hiding this comment

bakercp Aug 11, 2014

Choose a reason for hiding this comment

bilderbuchi Aug 12, 2014

Choose a reason for hiding this comment

ofTheo Aug 12, 2014

Choose a reason for hiding this comment

bakercp commented Aug 11, 2014

arturoc commented Aug 12, 2014

ofTheo commented Aug 12, 2014

bakercp commented Aug 12, 2014

danoli3 commented Aug 25, 2014

bakercp commented Aug 25, 2014

danoli3 commented Aug 27, 2014

danoli3 commented Sep 4, 2014

bakercp commented Sep 4, 2014

danoli3 commented Sep 4, 2014

tgfrerer commented Sep 4, 2014

danoli3 commented Sep 4, 2014

pizthewiz commented Sep 8, 2014

ofTheo commented Sep 15, 2014

danoli3 commented Sep 15, 2014

danoli3 commented Oct 7, 2014

bakercp commented Oct 7, 2014

danoli3 commented Oct 7, 2014

danoli3 commented Oct 14, 2014

bakercp commented Nov 24, 2014

danoli3 commented Nov 24, 2014

bakercp commented Nov 25, 2014

ofTheo commented Feb 8, 2015

admsyn commented Mar 8, 2015