-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oscpack 1.1.0 PR #3210
Oscpack 1.1.0 PR #3210
Conversation
@RossBencina - you can see the configurable buffer code in the last three commits. By default it doesn't do anything different to the 1.1.0 version. If you call UdpSocket::SetUdpBufferSize(65355); before opening sockets it sets the global socket variable for all osc sockets to use that buffer size. Tested with openFrameworks it behaves as expected with the image / blob sending example, but now allows the user to choose to increase the buffer size to whatever amount they want. Feel free to pull this in, or request changes. It could also be set to 65355 by default fairly easily ( 2^16 ), but I didn't want to change the default behavior, so will leave that up to you. |
thanks for taking this over! I see you have not renamed some of the windows files to disambiguate the filenames, see 9c103e4. This was necessary previously for OF (I think on VS?) so that the build process doesn't get confused, maybe it's not necessary anymore? |
@bilderbuchi - yes meant to go through and pull in the remaining stuff. |
yes, that's my hope, too! |
Okay - just tested this with the PG. Think this is good to merge. |
I think the problem was never with the makefile-based approach, but with IDE projects, i.e. xcode/codeblocks/VS... not sure though as I've never personally experienced that. |
@bilderbuchi the PG uses addons_config.mk too so it should be ok |
yeah - I just tested it with the PG - it works great. the addons_config system is really helpful! |
ah, great, didn't realize that Arturo! |
okay going to merge this if there are no objections |
Yay new oscpack! |
This PR continues #2513
Split into two commits.
- function to set udp buffer sizes - as discussed in #3106