Apothecary assimp formula update for 64bit / libc++ #3237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit shows the formula changes for OSX:
270075c
Also for iOS:
2574f98
The other commits are the changes needed to OF for the new assimp API.
One small issue I noticed is the astro boy model is coming in 100 times smaller with this version of assimp.
The 4 other models in the example load fine, but for some reason astroboy ( collada ) needs to be scaled by 100.0.
Feel free to send PRs against this branch for nix/win android etc.
Ping @arturoc