Updating axis on matrix change #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -143,6 +146,7 @@ void ofNode::setScale(float sx, float sy, float sz) { | |||
| void ofNode::setScale(const ofVec3f& s) { | |||
| this->scale = s; | |||
| createMatrix(); | |||
| updateAxis(); | |||
There was a problem hiding this comment.
createMatrix already calls updateAxis so it shooulnd't be necesary to call it here right?
arturoc
added a commit
that referenced
this pull request
Oct 11, 2014
Updating axis on matrix change
|
thanks! |
|
You know what, I think updateAxis() is unnecessary for setPosition too. I didn't think yesterday that on position change orientation stays the same... |
|
Can you quick fix it by removing this line? |
|
you are right, setPosition won't change the axis, i'll remove that line |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSideDir(), getLookAtDir() and getUpDir() return old vectors if you set a new matrix directly to a node.