Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniformize API: #3320

Merged
merged 1 commit into from
Oct 18, 2014
Merged

uniformize API: #3320

merged 1 commit into from
Oct 18, 2014

Conversation

arturoc
Copy link
Member

@arturoc arturoc commented Oct 18, 2014

loadMovie -> load
loadImage -> load
saveImage -> save
initGrabber -> setup

old methods are deprecated except in the base classes and implementations
where it's dropped completely

loadMovie -> load
loadImage -> load
saveImage -> save
initGrabber -> setup

old methods are deprecated except in the base classes and implementations
where it's dropped completely
@arturoc arturoc added this to the 0.9.0 milestone Oct 18, 2014
@ofTheo
Copy link
Member

ofTheo commented Oct 18, 2014

YES! ! !

@bakercp
Copy link
Member

bakercp commented Oct 18, 2014

I was just trying to explain this in class yesterday :) +1
On Oct 18, 2014 7:25 AM, "Theodore Watson" notifications@github.com wrote:

YES! ! !


Reply to this email directly or view it on GitHub
#3320 (comment)
.

@ofZach
Copy link
Contributor

ofZach commented Oct 18, 2014

+1 !

arturoc added a commit that referenced this pull request Oct 18, 2014
@arturoc arturoc merged commit e8faa07 into openframeworks:master Oct 18, 2014
@arturoc arturoc deleted the refactor-API branch October 18, 2014 13:11
@kylemcdonald
Copy link
Contributor

IT'S THE FUTURE!!

that said, there's still a number of these inconsistencies to fix ;) #1547

ofSoundPlayer::loadSound isn't even in that list, i feel like there's another issue out there that i'm forgetting.

@bakercp
Copy link
Member

bakercp commented Oct 22, 2014

Hey @arturoc and @kylemcdonald this is a definite step in the right direction -- should we be adding more uniform-ication requests in #1547 or should we start a new issue? I'm wondering about things like ofTexture::loadData() etc. too.

@arturoc
Copy link
Member Author

arturoc commented Oct 22, 2014

i think 'ofTexture::loadData()' is fine as it is, the rest of load methods are initializing the object while this is something you call after allocating to put new data into the texture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants