Add missing include path in ofxOsc's addon_config #3575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the way the makefiles and the PG work is that by default they include every path in libs and src recursively. if you want to do something different to that then you can specify it in the addons_config.mk that way most addons just work without any further config. |
|
so, close this unmerged, @arturoc ? I think I agree, since I don't remember compilation problems since we switched to that setup. |
|
Makes sense, I misinterpreted the setting as general include paths instead of specifically external / "extra" paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ofxOsc's addon_config didn't specify an include path of
libs/oscpack/src, which is necessary for some of oscpack's internal includes. Presumably this didn't affect the PG since it adds basically all paths, but it should probably be specified anyway.