Adds GL_BGRA format

[ghost]

Makes possible to draw Cairo or other BGRA swizzled images without calling super expensive swapRgb function.

[tgfrerer]

+1 =)

[tgfrerer]

Are you sure that should say GL_BGRA? i believe it should say GL_UNSIGNED_BYTE, in which case you could add it above next to GL_RGB etc.

[ghost]

You're right. Fixed!

[arturoc]

The internal format of a texture can't be GL_BGRA only GL_RGBA: https://www.opengl.org/sdk/docs/man/html/glTexImage2D.xhtml.

Then you upload using tex.loadData(data,GL_BGRA) with the new ofPixels based on pixel format instead of number of channels this should be happening automatically already just by allocating the pixels as OF_PIXELS_BGRA

[arturoc]

this: 70ab62c should fix it, now you can do tex.loadData(cairo.getImageSurfacePixels()) without specifying the format at all since the pixels already have the correct format. also when saving it'll avoid swapping the pixels twice as i think was doing before.

[ghost]

Then you upload using loadData(data,GL_BGRA) with the new ofPixels based on pixel format instead of number of channels this should be happening automatically already just by allocating the pixels as OF_PIXELS_BGRA

Ah, you're right! The trick was to allocate ofTexture as well:

  texture.allocate(w, h, GL_RGBA);
  buffer.allocate(w, h, OF_PIXELS_BGRA);

Don't know why, but explicitly allocating it as GL_RGBA fixes the render.

[arturoc]

yes the autoallocate in loadData is kind of handy for very basic things but as soon as you want to do something slightly different is not very reliable. it passes the format as internal which in lots of cases is not correct. i added a TODO some days ago to fix it by adding a function that guesses the internal from the format