tvOS - Apple TV OS Feature #4413
Conversation
|
ah wow thats cool! will have a look through and leave comments and questions about anything that stands out. if all good, we should merge this after 0.9 release. |
| @@ -326,7 +326,7 @@ - (BOOL)createAssetReaderWithTimeRange:(CMTimeRange)timeRange { | |||
| } | |||
|
|
|||
| //------------------------------------------------------------ add audio output. | |||
| double preferredHardwareSampleRate = [[AVAudioSession sharedInstance] currentHardwareSampleRate]; | |||
| double preferredHardwareSampleRate = [[AVAudioSession sharedInstance] sampleRate]; | |||
There was a problem hiding this comment.
does sampleRate compile on older iOS versions - 5.0 and up?
There was a problem hiding this comment.
iOS 6.0 and up. Since oF 9.1 is iOS 7.0+ Should be all good.
currentHardwareSampleRate was also deprecated in iOS 6.0, why it's an error for tvOS I think
There was a problem hiding this comment.
ok, i think the first thing we need to do is move the minimum ofxiOS support from the current 5.0 to 6.0. i agree its time to move it up since iOS 9.0 has been released.
we should do this in a separate PR and link it to a relevant issue.
i'll open up the issue now...
|
do you think that ofxtvOS might be too general as a name? |
|
do you think it will be cleaner to have a new app delegate and view controller for Apple TV? |
I think Apple have already made their stake on the name tvOS so it is unlikely to be used by other companies as that. Also by keeping with their name standard too, it will make it easier for those looking to build for it to find openFrameworks as an option too. ofxAppletvOS could work though if it is too ambiguous. Post release though, tvOS will be standard lingo to devs though, like iOS is for iPhone / iPad. |
Yes it might be cleaner as we can focus more on the specifics for tvOS 9.0, however there is a lot of overlap, since tvOS is basically the same as iOS however restricted in it's SDK, it doesn't allow for older SDK references that don't exist in tvOS and deprecated functions become a real issue. All the ifdefs currently are to get it to build and work. |
yeah good point. in which case it makes sense to include it in ofxiOS how about we create a folder inside ofxiOS for tvOS specific code, and in there we would have, it will be worth making ofxtvOSAppDelegate & ofxtvOSViewController as separate from ofxiOS. |
|
i was also thinking... with all those #ifdefs you had to add to a lot of the, its currently an issue with ofxiOS that it references all those classes as soon as you include so if this is cleaned up properly in ofxiOS, you then shouldn't need to add all those #ifdefs i'll try to do this clean up soon and send a PR through. |
|
hey @danoli3, ping me once you've made any updates to tvOS and i'll review. |
|
Awesome yeah looking at doing it later today Sent from my iPhone
|
Just an initial working version of oF 0.9 for Apple TV tvOS.
Requirements:
Changes:
Changes made include modifications to ofxiOS with some pre-processor defines to not expose certain functions that are not in the tvOS SDK (such as video grabber, mapkit, orientation code etc).