ofRectangle::intersects(const ofPoint& p0, const ofPoint& p1) fails in one case. Fixes #4871 #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ofLineSegmentIntersection(p0, p1, topLeft, topRight, p) || // cross top | ||
| ofLineSegmentIntersection(p0, p1, topRight, bottomRight, p) || // cross right | ||
| ofLineSegmentIntersection(p0, p1, bottomRight, bottomLeft, p) || // cross bottom | ||
| ofLineSegmentIntersection(p0, p1, bottomLeft, topLeft, p); // cross left | ||
| ofLineSegmentIntersection(p0, p1, bottomLeft, topLeft, p) || // cross left | ||
| (left == p0.x && top == p1.y) || // Special case 1. |
There was a problem hiding this comment.
comparing floats with == is not a good idea, this should be using some kind of epsilon or something like that
There was a problem hiding this comment.
Yes, was following the style in other places from the file. I'll update all.
|
can you change the title of this issue to something more descriptitve? i |
bakercp
changed the title
|
This now includes updates from #4958. |
|
i'll check this when i have a moment, i mostly need to merge it in the glm branch before merging it into master to be sure that i merge this individually since ofRectangle has changed quite a bit with glm |
|
@arturoc This should be ready to merge after CI checks. |
…orks into bugfix-ofRectangle
|
@arturoc This should be ready to merge after CI checks. |
|
@arturoc - This should be ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4871 for discussion.