Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix VS project template #6122

Merged

Conversation

hiroMTB
Copy link
Contributor

@hiroMTB hiroMTB commented Sep 7, 2018

Try to solve two issues.

With this PR's initial commit, Issue 1 has been solved. But Issue 2 still remains.

There are several output files should be placed inside of an intermediate file folder.
For example,

  • *.tlog folder
  • .log file
  • icon.rc file

And these changes should be tested on VS2018 and VS2015.

  • VS2017
  • VS2015 seems like oF0.10.0 is not compatible

More commits coming later.

Official documents about VS build macro
https://docs.microsoft.com/en-us/cpp/ide/common-macros-for-build-commands-and-properties?view=vs-2017

@hiroMTB
Copy link
Contributor Author

hiroMTB commented Sep 7, 2018

For reference, cinder is using following setup for Intermediate Directory (which can be used as $(IntDir) )
$(ProjectDir)build\$(Platform)\$(Configuration)\intermediate\

oF's Intermediate Directory is
obj\$(Configuration)\

@hiroMTB hiroMTB changed the title fix VS project template Bugfix VS project template Sep 7, 2018
@arturoc arturoc merged commit 06bea48 into openframeworks:patch-release Sep 8, 2018
@arturoc
Copy link
Member

arturoc commented Sep 8, 2018

thanks!

@hiroMTB
Copy link
Contributor Author

hiroMTB commented Sep 8, 2018

Thanks @arturoc
But I have one more commit must be added.
I already pushed but it doesn't appear here.
Here is a commit to my oF fork.
hiroMTB@9a6f4b9

Please feel free to commit directly if it's easier. ;-)

@hiroMTB
Copy link
Contributor Author

hiroMTB commented Sep 8, 2018

And couldn't find a general solution for issue 2.
but instead of changing oF itself, we can avoid this issue by setting a unique object file name to one of conflicting file.

Let's say we have addonA and addonB and both has MyFile.cpp.

  1. Open your VS project and right click MyFile.cpp file in solution explorer.
  2. Go to Properties -> C/C++ -> Output Files -> Object file name
  3. Change $(IntDir) to $(IntDir)/MyFile_from_addonB
  4. compile

This way, vs generates MyFile_from_addonB.obj under /obj folder.

olekristensen added a commit to olekristensen/openFrameworks that referenced this pull request Sep 12, 2018
* commit '06bea481039ab244eded2fabc450ad4e30585d03': (60 commits)
  Bugfix VS project template (openframeworks#6122)
  update libfreenect to fix ofxKinect on raspberry pi (openframeworks#6123)
  Fix ttf font bounding box calculations (openframeworks#6109)
  Speed up image loading (openframeworks#6035)
  fix const about `ofSerialize` in ofJson.h (openframeworks#6101)
  Revert "Update vs template, fixes openframeworks/projectGenerator#159"
  ofTtf: Fix some problems with outlines
  ofConstants: mark version as stable before release
  PG latest commit
  ofXml: fix attribute iterator
  ofXml::Attribute: add getName
  ofXml: add missing methods to remove attributes
  ofXml: add methods to remove child through a reference or move
  ofPixels.h: CLAMP -> ofClamp and include ofMath
  binding the listener method to the vSync param (openframeworks#6098)
  Android camera optimizations (openframeworks#6097)
  fix iOS / tvOS examples broken during docs sprint
  ofxAndroidGrabber: when changing camera ID close device if it was open
  android multi activity example: add manifest (openframeworks#6036)
  More efficient way for ofNode::getGlobalOrientation (3x~ faster) (openframeworks#6094)
  ...

# Conflicts:
#	apps/projectGenerator
#	libs/openFrameworks/app/ofAppGLFWWindow.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants