Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msys2 opencv4 #6252

Merged
merged 12 commits into from
Mar 15, 2019
Merged

Msys2 opencv4 #6252

merged 12 commits into from
Mar 15, 2019

Conversation

oxillo
Copy link
Contributor

@oxillo oxillo commented Mar 4, 2019

Update ofxOpenCv addon to use openCv 4 if available.
Some methods (especially HaarDetectObejct converted to their C++ equivalent)
Should correct #6202

@arturoc
Copy link
Member

arturoc commented Mar 4, 2019

Thanks so much for looking into this, it's really useful.

Couple of things.

  • You've added to the PR your vs code config, can you remove it?
  • The way you are doing the addons config is only compatible with the makefiles but won't work with the PG or the qtcreator wizard. What i did recently for another addon is to add an exception in the install_dependencies script that detects the version of the library and modifies addon_config.mk to change the file with whatever is needed. in this case changing opencv -> opencv4

@oxillo oxillo force-pushed the MSYS2_CV4 branch 2 times, most recently from 5d8358f to f8d7810 Compare March 6, 2019 17:55
Upgrade deprecated C API calls to their C++ equivalent (cvUndistort2 -> cv::undistort,  CvHaarClassifierCascade -> cv::CascadeClassifier, cvHaarDetectObjects -> cascade.detectMultiscale)
Old C API calls are guarded with USE_OLD_CV
Defines USE_OLD_CV if OpenCV version < 4.
@oxillo
Copy link
Contributor Author

oxillo commented Mar 6, 2019

Cleaned up VS code config;
Added the ofxOpenCv addon_config.mk modification in msys2 install_dependencies.
I was also thinking of having a script in the addon so people upgrading their system can upgrade the script.

@arturoc
Copy link
Member

arturoc commented Mar 15, 2019

i've just compiled opencv 4 for the platforms that use local libraries, can you change the script to instead fix it if you are using and old version? we could also just not have any fix and assume people need to have an up to date install of msys

@arturoc
Copy link
Member

arturoc commented Mar 15, 2019

actually no worries, i've just done the changes myself and included the needed fixes for other platforms...

@arturoc
Copy link
Member

arturoc commented Mar 15, 2019

going to merge this since msys is working fine now and keep working on the other platforms on a different PR.

Thanks!

@arturoc arturoc merged commit 529ffd8 into openframeworks:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants