Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten videoPlayerExample fix #7214

Conversation

Jonathhhan
Copy link
Contributor

No description provided.

@ofTheo
Copy link
Member

ofTheo commented Jan 16, 2023

@Jonathhhan - I think we shouldn't merge this one as it might break other platforms.
using isFrameNew for drawing could mean flashing frames if the video framerate is lower than the app frame rate.

We should probably just make things work if the camera or video hasn't uploaded the texture yet. Either with a dummy texture or track down the issue with returning an unallocated texture that breaks emscripten but not other platforms.

( hope that makes sense 🙂 )

@ofTheo ofTheo closed this Jan 16, 2023
@Jonathhhan
Copy link
Contributor Author

@ofTheo yes, of course. That sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants