-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emscripten audio video revision #7217
Emscripten audio video revision #7217
Conversation
Its not really a pull request, its more like a suggestion. It can be surely further optimized, but works quite well. |
Let my try to explain what the main changes are: Audio: Video: Please tell me, if I reduced too much, but until now everything seems to work as before (plus a few additional features like pan). |
3874d87
to
33370bf
Compare
@Jonathhhan thanks for this! |
@ofTheo the idea is, to remove redundant stuff, fix some stuff and add some features. |
Okay great @Jonathhhan 👍 - if you want to just let me know when this is good to merge. |
@ofTheo thank you for merging this. Actually I wanted to triple check it, to be sure there are no errors. But I checked it once again yesterday, and did not found anything so far. Maybe its better like that, instead of waiting for too long. The conflict with the grabber was just a space. |
Ahh yes! Was wondering if it was done. |
This is basically what I changed end of last year.
I compared it with my recent changes and it seems more complete (but I changed a lot).
I can also split it up into smaller parts.