-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emscripten: ofLaunchBrowser implementation #7621
Conversation
Allows one to use ofLaunchBrowser() in emscripten. Added an optional parameter to ofLaunchBrowser that passes the `target` parameter of the window.open() call. defaults to _blank for a fresh page.
Nice, thanks :) |
Thanks! |
…and provide adjusted interface #ifdef TARGET_EMSCRIPTEN
@ofTheo no rush for that! there's a bit of a design decision to make as the OS URL pathways don't allow the same target feature (at least on macOS and linux). so I don't know how it could be usefully used? if we want to unpollute the API of desktop we could have a specifc function defined on emscripten, splitting the top part of ofLaunchBrowser so it can be reused. |
…into artificiel-master
Allows one to use ofLaunchBrowser() in emscripten. Added an optional parameter to ofLaunchBrowser that passes the
target
parameter of the window.open() call. defaults to _blank for a fresh page.closes #7591