Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten: ofLaunchBrowser implementation #7621

Closed
wants to merge 11 commits into from

Conversation

artificiel
Copy link
Contributor

Allows one to use ofLaunchBrowser() in emscripten. Added an optional parameter to ofLaunchBrowser that passes the target parameter of the window.open() call. defaults to _blank for a fresh page.

closes #7591

Allows one to use ofLaunchBrowser() in emscripten. Added an optional parameter to ofLaunchBrowser that passes the `target` parameter of the window.open() call. defaults to _blank for a fresh page.
@Jonathhhan
Copy link
Contributor

Nice, thanks :)

@ofTheo
Copy link
Member

ofTheo commented Aug 28, 2023

Thanks!
I think this would need the target argument to be implemented for non emscripten platforms before we merge.

…and provide adjusted interface #ifdef TARGET_EMSCRIPTEN
@artificiel
Copy link
Contributor Author

@ofTheo no rush for that!

there's a bit of a design decision to make as the OS URL pathways don't allow the same target feature (at least on macOS and linux). so I don't know how it could be usefully used?

if we want to unpollute the API of desktop we could have a specifc function defined on emscripten, splitting the top part of ofLaunchBrowser so it can be reused.

@ofTheo ofTheo added this to the 0.12.1 milestone Aug 30, 2023
@artificiel artificiel mentioned this pull request Aug 31, 2023
36 tasks
@artificiel artificiel deleted the branch openframeworks:master September 12, 2023 14:55
@artificiel artificiel closed this Sep 12, 2023
@artificiel artificiel deleted the master branch September 12, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emscripten: no support for ofLaunchBrowser()?
3 participants