Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment out boost from install scripts, install_dependencies.sh using one line apt get #7838

Merged
merged 43 commits into from Jan 3, 2024

Conversation

dimitre
Copy link
Member

@dimitre dimitre commented Dec 23, 2023

This makes linux actions runs in less time.

@dimitre dimitre changed the title [actions] apt packages cache, install_dependencies.sh using one line apt get Remove boost from makefile, install_dependencies.sh using one line apt get Dec 26, 2023
@dimitre dimitre marked this pull request as ready for review December 26, 2023 19:58
@dimitre
Copy link
Member Author

dimitre commented Dec 26, 2023

@danoli3 I want your opinion on this one as it changes install scripts
I've noticed if we install one package at a time it spends some time on "reading database" so if we convert this to oneliner it can shave off about 2 minutes for installing dependencies.
Do you see any downside?
this is the specific change:

- installPackages ${PACKAGES}
+ apt-get -y -qq install ${PACKAGES}

@dimitre dimitre changed the title Remove boost from makefile, install_dependencies.sh using one line apt get install_dependencies.sh using one line apt get Jan 2, 2024
@dimitre dimitre changed the title install_dependencies.sh using one line apt get comment out boost from install scripts, install_dependencies.sh using one line apt get Jan 2, 2024
@dimitre
Copy link
Member Author

dimitre commented Jan 2, 2024

This is finally ready to go @ofTheo.
Don't mind the number of commits I've splitted this PR in other ones.

@dimitre dimitre merged commit 2f0a515 into openframeworks:master Jan 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant