-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ofFpsCounter with more precision using straight std::chrono #7966
Conversation
Finally! ready to go @ofTheo |
oh cool @dimitre - going to really hammer it this week! |
Nice. It is a direct replacement line by line, and keeping the same logic from original fps counter. |
@dimitre, I just did a simple test with setting the fps of the app and recalculating via ofFpsCounter and it looked good to me. While looking at the PR, I noticed these namespace lines at the top of openFrameworks/libs/openFrameworks/utils/ofTimerFps.h Lines 10 to 11 in 12f4a84
I think the appropriate
|
Thank you Nick, good catch. I'll remove this from .h files |
this PR circumvents could the work here expand into simplifying the std::chrono in |
@artificiel good idea, ofTime can be updated so all internal operations are done using std::chrono. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome keen to try this out
Yeah if you want to wrap it with the ofTime stuff now or later up to you |
@danoli3 it is just personal opinion but I don't see why using ofTime in 2024. |
okay if we passing on all targets lets get it in |
could you rebase it |
Rebased. No conflicts here |
@danoli3 outstanding work on the core, thanks for that. |
ofFpsCounter with more precision using straight std::chrono when possible.
filterAlpha is being calculated with double.
the removal of some includes shows other files were depending of the includes included here, so now they are more explicit.
this PR: