-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[critical bug fix] Osc scope2 #7981
Conversation
Small thing, but is this commit needed for this PR? |
yes I noticed in the GitHub actions some platforms were failing because of missing include (although macOS somehow has it without the explicit include) |
Just tested on Windows 10 and VS 2022 using the StressofxOscReceiver test and did not encounter any issues. :) |
When I add a ofxOscReceiver rc; to the setup() function, it prints "ready to roll" but hangs. Is this an issue that is addressed in another PR?
|
is that on windows? if so, please try #7979 if not I will try to reproduce. |
Yeah on Windows; #7979 fixes it! |
Thanks @artificiel @NickHardeman !!!! |
replaces #7978 which had a garbled commit