Download libs script update (adds #7907 wget2) - params and fixes deploy logs #8002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @danoli3 I'm testing now in osx and wget2 calls are being called once for each download. EDIT: in the other PR |
|
Yeah!! 2>/dev/null was preventing the visualisation! cURL's parallel needed some work though, fixed that up properly |
|
cURL wget2 |
|
woww that's great! I'm testing now in macOS and it is running great with wget2. |
|
Great. downloading once now. it seems to be downloading x86_64 here instead of arm |
|
Been testing on a few computers.
I was watching the cache files as well, it was downloading them and got stuck and some sort of a loop and stopped getting my bytes, looks like remote hung up on the transfer. Prior calls were fine with wget2, even to the same binaries
Side effect of checking if command function exists >= null should have handled that
** |
- fixes command determination artefact now tracks installed of curl/wget2/wget in variable - added wget2 params for override or continue last download (-nc) - t20 retries - console formatting - added error message if no commands installed
|
Downloader updates
|
|
have you seen this one? https://amber-lang.com |
|
I've just tested it seems to be working great here. a nice glob command to test all libs architectures cd $ofw/libs
file **/*.aand the results |
|
it would be great if we had ./scripts/osx/download_libs.sh using new downloader also :) |
|
You should run file **/*.a on the ultra mega xcframework with the macos scripts, its massif.
Its already powering that too Fixed: [osx]_[x86_64] |
|
I had this error now: after removing all libs folder it stopped working. and subsequent calling download_latest_libs.sh returns |
|
Good idea! version is great |
|
|
|
Yes maybe only because I've tested scripts under constructions, but it would be great to handle those also, in the case it happens somewhere else. |
…d and optimises - won't download if same
- files downloaded (zip/tar.bz2) are now stored in libs/download/ - creates libs/download for downloading zips/tars for optimisation - clean up of logs - not removing dl zip now - code to remove zips on start also done commented out
|
I thought I'd add another folder to libs 
downloader 3.1.0 wget/wget2 - now checks remote file vs local if found and optimises - won't download if same download_libs 2.1 -
|
- include overwrite off
cURLs progress bar |
|
Beautiful. install complete here. didnt have to remove any file. All very fast here in a slow rural internet connection via radio. Suggestions: Thanks for all the work. it is great here in macOS. I can test later in Windows |
|
Good to go. only reminding you of file permissions |
… other PRs of not the same hash. fallback to sha for non-prs
…so it just queries the content size and time rather than getting whole file
|
Linux 24.04 issues on restart actions/runner-images#9937 |
|
Sweet merging as fixes linux actions as well |
|
Yes! I've fixed it by removing sudo apt update which calls some services to restart, including the github actions. |
danoli3
added a commit
to danoli3/openFrameworks
that referenced
this pull request
Jun 6, 2024
…frameworks * commit '25d0a4ba0c8b8ee96123fc669a884ab9f3f77982': Download ProjectGenerator to downloads, optimise wont re-download if in sync (openframeworks#8012) ofxAssimpModelLoader addon_config.mk osx exclusions Downloader 3.2.3 - fixes for install detection and single url for curl (openframeworks#8009) Download libs script update (adds openframeworks#7907 wget2) - params and fixes deploy logs (openframeworks#8002) .mk removing repeated configs COREVIDEO_SILENCE_GL_DEPRECATION (openframeworks#8005) ios template update update addons folder in xcode template (openframeworks#8003) VS download latest x64 only (openframeworks#7999) # Conflicts: # scripts/apothecary # scripts/dev/download_libs.sh # scripts/osx/download_latest_libs.sh # scripts/templates/ios/emptyExample.xcodeproj/project.pbxproj
danoli3
added a commit
to danoli3/openFrameworks
that referenced
this pull request
Jun 18, 2024
* master: (244 commits) ofxAssimpModelLoader addon_config.mk osx exclusions Downloader 3.2.3 - fixes for install detection and single url for curl (openframeworks#8009) Downloader 3.2.3 - fixes for install detection and single url for curl Download libs script update (adds openframeworks#7907 wget2) - params and fixes deploy logs (openframeworks#8002) .mk removing repeated configs COREVIDEO_SILENCE_GL_DEPRECATION (openframeworks#8005) ios template update update addons folder in xcode template (openframeworks#8003) VS download latest x64 only (openframeworks#7999) Android 2024 template (openframeworks#7991) XCode macOS template update up (openframeworks#7996) msys2 improvements (openframeworks#7976) commented out .h files removed (openframeworks#7990) VS2022 FreeType Fix (openframeworks#7992) Update ofPixels.cpp (openframeworks#7989) ofAppNoWindow..h: #include ofEvents to complete the ofCoreEvents type (openframeworks#7943) ofFile::doesFileExist simplified (openframeworks#7970) fix unneeded reference for `add` of `bool`, `char` (openframeworks#7973) ofxOscReceiver: win32 implementation: shadow posix changes (openframeworks#7979) ... # Conflicts: # .gitignore # libs/openFrameworks/gl/ofGLProgrammableRenderer.cpp # libs/openFrameworks/gl/ofShader.cpp # libs/openFrameworks/gl/ofTexture.h # libs/openFrameworks/graphics/ofGraphicsBaseTypes.cpp # libs/openFrameworks/graphics/ofTrueTypeFont.cpp # libs/openFrameworks/graphics/ofTrueTypeFont.h # libs/openFrameworks/sound/ofAVEngineSoundPlayer.h # libs/openFrameworks/sound/ofSoundBaseTypes.h # libs/openFrameworks/utils/ofConstants.h # libs/openFrameworks/utils/ofThread.h # libs/openFrameworks/utils/ofURLFileLoader.cpp # libs/openFrameworks/utils/ofUtils.h # libs/openFrameworks/utils/ofXml.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks: @dimitre #7907 (add wget2 and parallel downloads)
Further Updated the downloader script to support changes for parallel downloads
Cleaned up download_libs with better logs and overwrite settings to the target download type