-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme for electron app #105
Conversation
Helpful for issues like #104 and #83 (comment) |
Pinging @danoli3 too who dug into this recently, would be good to know if this is a helpful format |
Awesome thanks! Makes a lot more sense :D! On 21 December 2015 at 10:30, Matt Felsen notifications@github.com wrote:
|
this looks great - thanks! merging! |
Thanks, nice start! |
Oh good point, I always forget that about node/npm. I'll add a note and
Is anyone aware of any node version dependencies? I've used & built the On Mon, Dec 21, 2015 at 5:26 PM Daan de Lange notifications@github.com
|
Whoops, that's homebrew + nvm. Corrected |
one thing I'd like to mention in the readme (I am making an issue here just to remind myself to add a note) is the use of "npm-shrinkwrap.json" ie: to fix a bug that was building packages on osx incorrectly so they were failing on 10.8. I think it's useful to mention this in case anyone starts manipulating the modules / etc as I'm not sure if shrinkwrap needs to be regenerated, etc. (also this bug might be fixed by now so if we can remove this, it make the whole thing less fragile) I need to do a bit of research to remember the problem and solution but I'll add this shortly. |
@ofZach I played around with shrinkwrap for a bit but could not get it to work! So I can't really test this, and I'm not sure how to test/reproduce the issues you saw on 10.8, so I'll leave it to you to figure out 😄 Here's the bit I wrote for the readme which I'm leaving out for now, but feel free to re-use later if you like: DevelopingThis package is shrinkwrapped!We use
|
thanks it's gonna take me a few days to get my gears cranking again. also it looks like this issue: has been fixed upstream so we might not even need shrinkwrap.... It was basically being used to point to a specific fix upstream. gonna check.... |
Gotcha. All good, I'm on a pg roll today 😎 |
First pass at adding some documentation on how to get the electron fronted up & running. Some of the docs will probably soon be outdated if folders are renamed (which I do in my forthcoming PR) and there are some steps which should get automated or have scripts for, but I believe this is what's necessary as-is, so we gotta start somewhere 😄