✨(jobs) add support for pre/post deployment jobs #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some jobs require to be run before deploying an application, hence we introduced a way to filter jobs and execute them before or after creating deployments. Filtering is based on the "job_type" label, pre-deployment jobs must be labelled with job_type="pre" and post-deployment jobs must be labelled with job_type="post".
lunika
approved these changes
Dec 20, 2018
|
Once openfun/openedx-docker#84 has been merged, we need to make a new release of openedx-docker (e.g. |
jmaupetit
force-pushed
the
add-pre-post-jobs
branch
2 times, most recently
from
131d7dc
to
eeb0e60
Compare
Recent changes in vault variable namespacing had not been propagated in internationalization-related objects where the TX_TOKEN variable is expected to be defined.
jmaupetit
force-pushed
the
add-pre-post-jobs
branch
from
eeb0e60
to
f6f7149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some jobs require to be run before deploying an application, hence we need a way to filter jobs and execute them before or after creating deployments.
Proposal
Filtering is based on the
job_typelabel, pre-deployment jobs must be labelled withjob_type: "pre"and post-deployment jobs must be labelled withjob_type: "post". Jobs withoutjob_typelabel will be considered as post-deployment jobs.For now the only pre-deployment job is edxapp's internationalization job.